[App Configuration] - Fix test #36103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
minhanh-phan and
jimmyca15
as code owners
zhiyuanliang-ms
requested review from
zhenlan,
juniwang and
RichardChen820
as code owners
github-actions
bot
added
the
App Configuration
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test in the App Configuration package by removing a sanity check that was causing failures during live tests. The issue occurred when parallel tests were adding labels concurrently, causing the sanity check comparison to fail unexpectedly.
- Commented out the sanity check code that compares labels from two different iteration methods
- Added explanatory comment describing why the sanity check was removed
| } | ||
|
|
||
| let labelsViaPageIterator: SettingLabel[] = []; | ||
| /* |
There was a problem hiding this comment.
The comment should use proper TSDoc format with /** instead of /* for multi-line comments in TypeScript files.
Suggested change
| /* | |
| /** |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/app-configuration
Issues associated with this PR
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5404744&view=logs&j=123e026e-235d-5e25-85c7-c02862642caa&t=cb96b3e6-6106-5d1b-9b45-a11f7486aeb2
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists