Skip to content

[App Configuration] - Fix test #36103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[App Configuration] - Fix test #36103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions sdk/appconfiguration/app-configuration/test/public/utils/testHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,16 @@ export async function toSortedLabelsArray(
labels.push(label);
}

let labelsViaPageIterator: SettingLabel[] = [];
/*
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should use proper TSDoc format with /** instead of /* for multi-line comments in TypeScript files.

Suggested change
/*
/**

Copilot uses AI. Check for mistakes.

Comment out the sanity check. During the live test, there might be other parallel tests adding labels, which causes the sanity check to fail.
*/
// let labelsViaPageIterator: SettingLabel[] = [];

for await (const page of pagedIterator.byPage()) {
labelsViaPageIterator = labelsViaPageIterator.concat(page.items);
}
// for await (const page of pagedIterator.byPage()) {
// labelsViaPageIterator = labelsViaPageIterator.concat(page.items);
// }

// just a sanity-check
assert.deepEqual(labels, labelsViaPageIterator);
// assert.deepEqual(labels, labelsViaPageIterator);

labels.sort((a, b) => (compareFn ? compareFn(a, b) : `${a.name}`.localeCompare(`${b.name}`)));

Expand Down