[App Configuration] - Fix feature flag model #36104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
bterlson,
a team,
minhanh-phan,
jimmyca15,
zhenlan,
juniwang and
RichardChen820
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the feature flag model in the Azure App Configuration SDK to align with the official FeatureManagement schema. The main purpose is to add the missing requirement_type field and make the id field required in the feature flag structure.
Key Changes
- Added
requirementTypefield to feature flag conditions with "All" or "Any" values - Changed
idfield from optional to required in the feature flag value interface - Updated serialization/deserialization logic to handle the new
requirement_typefield
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/internal/jsonModels.ts |
Updated JSON model to add requirement_type field and make id required |
src/featureFlag.ts |
Added requirementType to public interface and updated helper functions for serialization |
review/app-configuration-node.api.md |
Updated API documentation to reflect interface changes |
test/public/featureFlag.spec.ts |
Updated test fixtures to include required fields |
assets.json |
Updated asset tag reference for test recordings |
github-actions
bot
added
the
App Configuration
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/app-configuration
Issues associated with this PR
Describe the problem that is addressed by this PR
The feature flag model is missing the
requirement_type" field. Also,id` should be a required field.The App Configuration feature flag schema can be found here
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists