Skip to content

[App Configuration] - Fix feature flag model #36104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[App Configuration] - Fix feature flag model #36104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f555ad4
fix feature flag model
zhiyuanliang-ms Oct 2, 2025
84b2fd6
update sample
zhiyuanliang-ms Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/appconfiguration/app-configuration/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/appconfiguration/app-configuration",
"Tag": "js/appconfiguration/app-configuration_bdaf29d71a"
"Tag": "js/appconfiguration/app-configuration_48f15db7c6"
}
3 changes: 2 additions & 1 deletion sdk/appconfiguration/app-configuration/review/app-configuration-node.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,12 @@ export interface FeatureFlagValue {
name: string;
parameters?: Record<string, unknown>;
}[];
requirementType?: "All" | "Any";
};
description?: string;
displayName?: string;
enabled: boolean;
id?: string;
id: string;
}

// @public
Expand Down
12 changes: 11 additions & 1 deletion sdk/appconfiguration/app-configuration/src/featureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface FeatureFlagValue {
/**
* Id for the feature flag.
*/
id?: string;
id: string;
/**
* A Feature filter consistently evaluates the state of a feature flag.
* Our feature management library supports three types of built-in filters: Targeting, TimeWindow, and Percentage.
Expand All @@ -32,6 +32,7 @@ export interface FeatureFlagValue {
*/
conditions: {
clientFilters: { name: string; parameters?: Record<string, unknown> }[];
requirementType?: "All" | "Any";
};
/**
* Description of the feature.
Expand Down Expand Up @@ -76,6 +77,11 @@ export const FeatureFlagHelper = {
display_name: featureFlag.value.displayName,
};

if (featureFlag.value.conditions.requirementType) {
jsonFeatureFlagValue.conditions.requirement_type =
featureFlag.value.conditions.requirementType;
}

const configSetting = {
...featureFlag,
key,
Expand Down Expand Up @@ -117,6 +123,10 @@ export function parseFeatureFlag(
key,
contentType: featureFlagContentType,
};

if (jsonFeatureFlagValue.conditions.requirement_type) {
featureflag.value.conditions.requirementType = jsonFeatureFlagValue.conditions.requirement_type;
}
return featureflag;
}

Expand Down
3 changes: 2 additions & 1 deletion sdk/appconfiguration/app-configuration/src/internal/jsonModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
export type JsonFeatureFlagValue = {
conditions: {
client_filters: { name: string; parameters?: Record<string, unknown> }[];
requirement_type?: "All" | "Any";
};
description?: string;
enabled: boolean;
id?: string;
id: string;
display_name?: string;
};

Expand Down
4 changes: 3 additions & 1 deletion sdk/appconfiguration/app-configuration/test/public/featureFlag.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ describe("AppConfigurationClient - FeatureFlag", () => {
baseSetting = {
value: {
conditions: {
requirementType: "Any",
clientFilters: [
{
name: "Microsoft.TimeWindow",
Expand All @@ -51,6 +52,7 @@ describe("AppConfigurationClient - FeatureFlag", () => {
{ name: "Microsoft.Percentage", parameters: { Value: 25 } },
],
},
id: "name-1",
enabled: false,
description: "I'm a description",
displayName: "for display",
Expand Down Expand Up @@ -202,7 +204,7 @@ describe("AppConfigurationClient - FeatureFlag", () => {
`name-1${Math.floor(Math.random() * 1000)}`,
)}`,
isReadOnly: false,
value: { conditions: { clientFilters: [] }, enabled: true },
value: { conditions: { clientFilters: [] }, id: "name-1", enabled: true },
};
});

Expand Down
Loading