Fix terminalUpdateStatuses to exclude failed status #36709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
terminalUpdateStatusesarray included "failed", which could cause failed operations to be incorrectly marked as succeeded if the explicit failure check was bypassed.Change
Removed "failed" from
terminalUpdateStatusesinmemoryStoreUpdatePoller.ts:Logic Flow
The
applyUpdateStatefunction handles statuses in this order:state.status = "failed"terminalUpdateStatusescheck → setsstate.status = "succeeded"state.status = "running"With "failed" in
terminalUpdateStatuses, any logic error allowing "failed" to reach line 121 would incorrectly mark it as succeeded. This fix ensures only non-error terminal statuses ("completed", "superseded") are treated as success.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.