Skip to content

Conversation

ArcturusZhang
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added CodeGen Issues that relate to code generation Mgmt This issue is related to a management package. labels Aug 12, 2025
@ArcturusZhang ArcturusZhang force-pushed the bump-azure-generator-version branch from ff9e9f9 to 5437d5d Compare August 13, 2025 07:57
@ArcturusZhang ArcturusZhang marked this pull request as ready for review August 13, 2025 09:35
@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 09:35
Copilot

This comment was marked as outdated.

@ArcturusZhang ArcturusZhang requested a review from Copilot August 13, 2025 12:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies for the Azure Management Generator to newer versions. The update includes both TypeSpec-related packages and Microsoft.TypeSpec.Generator packages, along with necessary code adjustments to accommodate API changes in the updated dependencies.

  • Updates all TypeSpec and Azure tools packages to their latest versions (e.g., @typespec/compiler from 1.1.0 to 1.3.0)
  • Updates Microsoft.TypeSpec.Generator packages from alpha.20250731.2 to alpha.20250811.4
  • Refactors pagination visitor code to handle changes in the underlying framework's method signature patterns

Reviewed Changes

Copilot reviewed 7 out of 62 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
eng/packages/http-client-csharp-mgmt/package.json Updates all TypeSpec and Azure tools dependencies to newer versions
eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/Common/InputFactory.cs Adds missing boolean parameter to InputModelProperty constructor
eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/Common/Azure.Generator.Management.Tests.Common.csproj Updates Microsoft.TypeSpec.Generator package versions
eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/Azure.Generator.Mgmt.Tests.csproj Updates Microsoft.TypeSpec.Generator package versions
eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/PaginationVisitor.cs Refactors pagination logic to handle framework changes, extracts helper methods
eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Azure.Generator.Management.csproj Updates Microsoft.TypeSpec.Generator package versions
eng/Packages.Data.props Updates AzureGeneratorVersion to match the new dependency version
Files not reviewed (1)
  • eng/packages/http-client-csharp-mgmt/package-lock.json: Language not supported

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@live1206 live1206 merged commit 87a6d64 into Azure:main Aug 14, 2025
41 checks passed
@ArcturusZhang ArcturusZhang deleted the bump-azure-generator-version branch August 15, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CodeGen Issues that relate to code generation Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants