[Identity] Add BrokerCredential as part of the dev credentials #51944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanCrd
requested review from
maorleger,
pvaneck,
scottaddie,
chlowell,
anannya03 and
minhanh-phan
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
There was a problem hiding this comment.
Pull Request Overview
This PR adds BrokerCredential to the development credentials chain when AZURE_TOKEN_CREDENTIALS is set to dev. The fix addresses a bug where BrokerCredential was only available in the default credential chain but not when specifically using development credentials.
Key changes:
- Modifies the dev credentials creation to use a mutable list instead of an array literal
- Adds conditional logic to include
BrokerCredentialin both dev and default credential chains
scottaddie
reviewed
Aug 12, 2025
Co-authored-by: Scott Addie <[email protected]>
…s://github.com/JonathanCrd/azure-sdk-for-net into identity-bug-brokercredential-as-devcredential
christothes
reviewed
Aug 13, 2025
This reverts commit befec4a.
…credential-as-devcredential
christothes
approved these changes
Aug 20, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
|
/check-enforcer evaluate |
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51886
This PR fixes a bug in which
BrokerCredentialwas not added whenAZURE_TOKEN_CREDENTIALSis set todev