Skip to content

[Identity] Add BrokerCredential as part of the dev credentials #51944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 20, 2025
+16 −4
Merged

[Identity] Add BrokerCredential as part of the dev credentials #51944

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6caf865
Add Broker Credential to the dev credential chains
JonathanCrd Aug 12, 2025
ddd31e9
Merge branch 'main' into identity-bug-brokercredential-as-devcredential
JonathanCrd Aug 12, 2025
eb8291e
Update Changelog
JonathanCrd Aug 12, 2025
9c60fe9
Update sdk/identity/Azure.Identity/CHANGELOG.md
JonathanCrd Aug 12, 2025
0b9d531
Modify test for new behaviour
JonathanCrd Aug 12, 2025
f31fd2b
Merge branch 'identity-bug-brokercredential-as-devcredential' of http…
JonathanCrd Aug 12, 2025
befec4a
Always include the Broker in the chain
JonathanCrd Aug 13, 2025
5c3d0f5
Revert "Always include the Broker in the chain"
JonathanCrd Aug 20, 2025
40c3b6d
Merge remote-tracking branch 'upstream/main' into identity-bug-broker…
JonathanCrd Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity.Broker/tests/DefaultAzureCredentialFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void ValidateDefaultAzureCredentialAZURE_TOKEN_CREDENTIALS_Honored_WithBr
Assert.IsTrue(chain.Any(cred => cred is VisualStudioCredential));
Assert.IsTrue(chain.Any(cred => cred is AzureDeveloperCliCredential));
Assert.IsTrue(chain.Any(cred => cred.GetType() == typeof(VisualStudioCodeCredential)));
Assert.IsFalse(chain.Any(cred => cred.GetType() == typeof(InteractiveBrowserCredential)));
Assert.IsTrue(chain.Any(cred => cred.GetType() == typeof(InteractiveBrowserCredential)));
}
else if (credSelection == Constants.ProdCredentials)
{
Expand Down
2 changes: 2 additions & 0 deletions sdk/identity/Azure.Identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- `BrokerCredential` is now included in the chain when `AZURE_TOKEN_CREDENTIALS` is set to `dev` and the `Azure.Identity.Broker` package is installed.

### Other Changes

## 1.15.0 (2025-08-11)
Expand Down
17 changes: 14 additions & 3 deletions sdk/identity/Azure.Identity/src/DefaultAzureCredentialFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,21 @@ public TokenCredential[] CreateCredentialChain()
{
if (_useDevCredentials)
{
return
[
var devCredentials = new List<TokenCredential>
{
CreateVisualStudioCredential(),
CreateVisualStudioCodeCredential(),
CreateAzureCliCredential(),
CreateAzurePowerShellCredential(),
CreateAzureDeveloperCliCredential()
];
};

if (TryCreateDevelopmentBrokerOptions(out InteractiveBrowserCredentialOptions brokerOptions))
{
devCredentials.Add(CreateBrokerCredential(brokerOptions));
}

return devCredentials.ToArray();
}
else if (_useProdCredentials)
{
Expand Down Expand Up @@ -98,6 +105,10 @@ public TokenCredential[] CreateCredentialChain()
{
chain.Add(CreateManagedIdentityCredential());
}
if (!Options.ExcludeBrokerCredential && TryCreateDevelopmentBrokerOptions(out InteractiveBrowserCredentialOptions brokerOptions))
{
chain.Add(CreateBrokerCredential(brokerOptions));
}
}

if (!_useProdCredentials)
Expand Down