Resolve Crashing VerifyChangeLogs
#42545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR resolves critical build failures in the VerifyChangeLogs process and regression testing pipeline by fixing path resolution and Python installation issues. The changes address scenarios where relative paths were causing failures when scripts were executed from different working directories.
Key changes:
- Fixed path resolution issues in the changelog verification process by using absolute paths
- Updated regression pipeline to use the standardized
$(PIP_EXE)variable instead of hardcodedpython -m pip
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/scripts/Language-Settings.ps1 | Fixed path resolution for azure-sdk-tools installation and get_package_properties.py script execution by using absolute paths |
| eng/pipelines/templates/jobs/regression.yml | Updated pip installation command to use the standardized $(PIP_EXE) variable |
Co-authored-by: Copilot <[email protected]>
mccoyp
approved these changes
Aug 15, 2025
weshaggard
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Sorry folks, I actually ran an internal build on the changeset that caused this break,
so I'm not certain how I managed to break the world on verify changelog in the way I did.This is because I ran it against the refs/pull/42545/merge, it resolved to runverify-changelogs, NOT the version that crashes on internal.test build proving out the fix on a service that was hitting this on their scheduled build