Skip to content

Resolve Crashing VerifyChangeLogs #42545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2025
Merged

Resolve Crashing VerifyChangeLogs #42545

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bd6b15f
ensure we have on this guy
scbedd Aug 14, 2025
4855cc6
ensure that we can install using absolute path if necessary
scbedd Aug 14, 2025
86ced5e
a couple additional
scbedd Aug 15, 2025
d6ca65d
ensure this is fixed everywhere
scbedd Aug 15, 2025
c1f4a5f
also add a fix for the regression break
scbedd Aug 15, 2025
30c3071
cleanup build
scbedd Aug 15, 2025
830e2dc
Update eng/scripts/Language-Settings.ps1
scbedd Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/templates/jobs/regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:

- pwsh: |
mkdir -p $(TEST_PROXY_FOLDER)
python -m pip install -r eng/regression_tools.txt
$(PIP_EXE) install -r eng/regression_tools.txt
displayName: 'Prep Environment'

- template: /eng/common/testproxy/test-proxy-tool.yml
Expand Down
10 changes: 6 additions & 4 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,19 +161,21 @@ function Get-AllPackageInfoFromRepo ($serviceDirectory)
$allPkgPropLines = $null
try
{
$pathToBuild = (Join-Path $RepoRoot "tools" "azure-sdk-tools[build]")
# Use ‘uv pip install’ if uv is on PATH, otherwise fall back to python -m pip
if (Get-Command uv -ErrorAction SilentlyContinue) {
Write-Host "Using uv pip install"
$null = uv pip install "./tools/azure-sdk-tools[build]"
$null = uv pip install "$pathToBuild"
$freezeOutput = uv pip freeze
Write-Host "Pip freeze output: $freezeOutput"
} else {
Write-Host "Using python -m pip install"
$null = python -m pip install "./tools/azure-sdk-tools[build]" -q -I
$null = python -m pip install "$pathToBuild" -q -I
}

Write-Host "Running get_package_properties.py to retrieve package properties"
$allPkgPropLines = python (Join-path eng scripts get_package_properties.py) -s $searchPath
$scriptLoc = Join-path $RepoRoot eng scripts get_package_properties.py
Write-Host "Running '$scriptLoc' to retrieve package properties"
$allPkgPropLines = python $scriptLoc -s (Join-Path $RepoRoot $searchPath)
}
catch
{
Expand Down
Loading