Skip to content

Conversation

@JC-386
Copy link
Member

@JC-386 JC-386 commented Dec 31, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@melionel
Copy link

melionel commented Jan 5, 2026

    # Get tools from AzureAIToolClient

this comment does not make sense


Refers to: sdk/agentserver/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/tool_client.py:93 in 7ac2d25. [](commit_id = 7ac2d25, deletion_comment = False)

@melionel
Copy link

melionel commented Jan 5, 2026

---------------------------------------------------------

why not put this file under 'tools' folder?


Refers to: sdk/agentserver/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/tool_client.py:1 in 7ac2d25. [](commit_id = 7ac2d25, deletion_comment = False)

@melionel
Copy link

melionel commented Jan 5, 2026

    for azure_tool in azure_tools:

rename to foundry_tool ?


Refers to: sdk/agentserver/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/tool_client.py:100 in 7ac2d25. [](commit_id = 7ac2d25, deletion_comment = False)

@melionel
Copy link

melionel commented Jan 5, 2026

    azure_tools = await self._tool_client.list_tools()

missing required arguments ?


Refers to: sdk/agentserver/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/tool_client.py:97 in 7ac2d25. [](commit_id = 7ac2d25, deletion_comment = False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants