-
Notifications
You must be signed in to change notification settings - Fork 303
Initial Service Bus crate #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the initial ServiceBus crate for Azure SDK for Rust, providing a comprehensive implementation for Azure Service Bus messaging capabilities. The implementation includes core clients, message types, authentication methods, and extensive test coverage.
- Initial ServiceBus crate with Client, Sender, and Receiver components
- Comprehensive test suite covering authentication, batching, scheduling, and topic/subscription scenarios
- Azure DevOps CI pipeline configuration and test infrastructure setup
Reviewed Changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
ci.yml | Azure DevOps pipeline configuration for ServiceBus CI/CD |
test-resources.bicep | Bicep template for provisioning test infrastructure resources |
test-resources-post.ps1 | Post-deployment script for retrieving connection strings |
test-resources-pre.ps1 | Pre-deployment setup script placeholder |
tests/README.md | Comprehensive documentation for running live tests |
tests/common/mod.rs | Common test utilities and environment variable helpers |
tests/servicebus_*.rs | Extensive test suite covering all major ServiceBus functionality |
Comments suppressed due to low confidence (3)
sdk/servicebus/azure_messaging_servicebus/tests/servicebus_client.rs
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure_messaging_servicebus/tests/servicebus_client.rs
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure_messaging_servicebus/tests/servicebus_client.rs
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
535a370
to
a1be98a
Compare
d7ff1de
to
5acc786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would liek to see all the client and method options fixed, at least. Added a few more nits, but those could be done in a subsequent PR.
26c6514
to
0662c92
Compare
Initial ServiceBus crate Create the initial structure for the ServiceBus crate. Includes tests, docs, and the basic clients: - Client - Sender - Receiver - Message Types - Error handling
0662c92
to
c661eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most - if not all of this - was stated before which you may have already captured, but I wanted to get some of the bigger things recorded since the PR was recreated (or squashed? I don't recall).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% upset by this code.
ServiceBus crate
Initial ServiceBus crate
Create the initial structure for the ServiceBus crate. Includes tests, docs, and the basic clients: