Skip to content

Conversation

RickWinter
Copy link
Member

ServiceBus crate

Initial ServiceBus crate

Create the initial structure for the ServiceBus crate. Includes tests, docs, and the basic clients:

  • Client
  • Sender
  • Receiver
  • Message Types
  • Error handling

@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 04:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the initial ServiceBus crate for Azure SDK for Rust, providing a comprehensive implementation for Azure Service Bus messaging capabilities. The implementation includes core clients, message types, authentication methods, and extensive test coverage.

  • Initial ServiceBus crate with Client, Sender, and Receiver components
  • Comprehensive test suite covering authentication, batching, scheduling, and topic/subscription scenarios
  • Azure DevOps CI pipeline configuration and test infrastructure setup

Reviewed Changes

Copilot reviewed 40 out of 42 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
ci.yml Azure DevOps pipeline configuration for ServiceBus CI/CD
test-resources.bicep Bicep template for provisioning test infrastructure resources
test-resources-post.ps1 Post-deployment script for retrieving connection strings
test-resources-pre.ps1 Pre-deployment setup script placeholder
tests/README.md Comprehensive documentation for running live tests
tests/common/mod.rs Common test utilities and environment variable helpers
tests/servicebus_*.rs Extensive test suite covering all major ServiceBus functionality
Comments suppressed due to low confidence (3)

Copy link

github-actions bot commented Aug 5, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure_messaging_servicebus

@heaths heaths changed the title ServiceBus crate Initial Service Bus crate Aug 5, 2025
@heaths heaths marked this pull request as draft August 6, 2025 20:06
@RickWinter RickWinter force-pushed the service_bus branch 8 times, most recently from 535a370 to a1be98a Compare August 11, 2025 22:49
@RickWinter RickWinter marked this pull request as ready for review August 11, 2025 23:02
@RickWinter RickWinter force-pushed the service_bus branch 3 times, most recently from d7ff1de to 5acc786 Compare August 12, 2025 22:31
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would liek to see all the client and method options fixed, at least. Added a few more nits, but those could be done in a subsequent PR.

@RickWinter RickWinter mentioned this pull request Aug 18, 2025
43 tasks
@RickWinter RickWinter force-pushed the service_bus branch 4 times, most recently from 26c6514 to 0662c92 Compare August 19, 2025 15:41
Initial ServiceBus crate

Create the initial structure for the ServiceBus crate. Includes tests, docs, and the basic clients:
- Client
- Sender
- Receiver
- Message Types
- Error handling
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most - if not all of this - was stated before which you may have already captured, but I wanted to get some of the bigger things recorded since the PR was recreated (or squashed? I don't recall).

Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% upset by this code.

@RickWinter RickWinter merged commit ab691d8 into Azure:main Aug 20, 2025
17 checks passed
@RickWinter RickWinter deleted the service_bus branch August 20, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants