Skip to content

test: Make a test fail if env var constants change#1568

Merged
aramase merged 3 commits intoAzure:mainfrom
chlowell:patch-1
May 6, 2025
Merged

test: Make a test fail if env var constants change#1568
aramase merged 3 commits intoAzure:mainfrom
chlowell:patch-1

Conversation

@chlowell
Copy link
Member

Downstream consumers such as the Azure SDK depend on these values, so it helps to have a test that would fail if they ever changed.

@chlowell chlowell marked this pull request as ready for review March 11, 2025 17:29
@chlowell chlowell requested review from aramase and enj as code owners March 11, 2025 17:29
@aramase aramase changed the title Make a test fail if env var constants change test: Make a test fail if env var constants change Mar 27, 2025
@aramase
Copy link
Member

aramase commented Mar 27, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aramase
Copy link
Member

aramase commented May 6, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase enabled auto-merge (squash) May 6, 2025 00:01
@aramase aramase merged commit 5e9be4c into Azure:main May 6, 2025
21 checks passed
@chlowell chlowell deleted the patch-1 branch May 6, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants