Skip to content

test: Make a test fail if env var constants change #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aramase merged 3 commits into from
May 6, 2025
Merged

test: Make a test fail if env var constants change #1568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95c415d
Make a test fail if env var constants change
chlowell Mar 11, 2025
694df61
Merge branch 'main' into patch-1
aramase Mar 27, 2025
25c208e
Merge branch 'main' into patch-1
aramase May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/webhook/webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,21 +509,23 @@ func TestAddEnvironmentVariables(t *testing.T) {
expectedContainer: corev1.Container{
Name: "cont1",
Image: "image",
// this test uses literals instead of constants for env var
// names so that it will fail if the constant values change
Env: []corev1.EnvVar{
{
Name: AzureClientIDEnvVar,
Name: "AZURE_CLIENT_ID",
Value: "clientID",
},
{
Name: AzureTenantIDEnvVar,
Name: "AZURE_TENANT_ID",
Value: "tenantID",
},
{
Name: AzureFederatedTokenFileEnvVar,
Name: "AZURE_FEDERATED_TOKEN_FILE",
Value: filepath.Join(TokenFileMountPath, TokenFilePathName),
},
{
Name: AzureAuthorityHostEnvVar,
Name: "AZURE_AUTHORITY_HOST",
Value: "https://login.microsoftonline.com/",
},
},
Expand Down
Loading