Skip to content

Bump vitest from 4.0.18 to 4.1.2 in /src/Bicep.Cli.E2eTests#19301

Open
dependabot[bot] wants to merge 8 commits intomainfrom
dependabot/npm_and_yarn/src/Bicep.Cli.E2eTests/vitest-4.1.2
Open

Bump vitest from 4.0.18 to 4.1.2 in /src/Bicep.Cli.E2eTests#19301
dependabot[bot] wants to merge 8 commits intomainfrom
dependabot/npm_and_yarn/src/Bicep.Cli.E2eTests/vitest-4.1.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 29, 2026

Bumps vitest from 4.0.18 to 4.1.2.

Release notes

Sourced from vitest's releases.

v4.1.2

This release bumps Vitest's flatted version and removes version pinning to resolve flatted's CVE related issues (vitest-dev/vitest#9975).

   🐞 Bug Fixes

    View changes on GitHub

v4.1.1

   🚀 Features

   🐞 Bug Fixes

    View changes on GitHub

v4.1.0

Vitest 4.1 is out!

... (truncated)

Commits
  • fc6f482 chore: release v4.1.2
  • 6f97b55 feat: disable colors if agent is detected (#9851)
  • b3c992c fix(coverage): correct coverageConfigDefaults values and types (#9940)
  • 7c06598 fix: ensure sequential mock/unmock resolution (#9830)
  • f54abad chore: add typo-checker skill and fix typos (#9963)
  • 7aa9377 fix: don't resolve setupFiles from parent directory (#9960)
  • 1f2d318 chore: release v4.1.1
  • ebfde79 refactor: rename matchesTagsFilter to matchesTags (#9956)
  • 5611500 feat(experimental): introduce experimental.vcsProvider (#9928)
  • eec53d9 feat(experimental): expose matchesTagsFilter to test if the current filter ...
  • Additional commits viewable in compare view

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 29, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 29, 2026 23:33
@microsoft-github-policy-service microsoft-github-policy-service bot added the auto-merge Automatically merge this PR label Mar 29, 2026
Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

Test this change out locally with the following install scripts (Action run 23912689871)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 23912689871
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 23912689871"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 23912689871
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 23912689871"

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/src/Bicep.Cli.E2eTests/vitest-4.1.2 branch from b3ff081 to 51d4637 Compare March 30, 2026 00:09
Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brendandburns
Copy link
Copy Markdown
Member

@dependabot rebase

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.0.18 to 4.1.2.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.2/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 4.1.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/src/Bicep.Cli.E2eTests/vitest-4.1.2 branch from 51d4637 to c11aa97 Compare March 30, 2026 20:17
Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brendandburns
Copy link
Copy Markdown
Member

@copilot please fix CI/CD errors.

… for live tests

Agent-Logs-Url: https://github.com/Azure/bicep/sessions/ab951e65-7a72-4df4-92f2-f91d22868b56

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

@copilot please fix CI/CD errors.

Fixed in ed87fe5.

The CI failure was caused by vitest 4.1.2 introducing a dependency on rolldown, which requires Node.js ^20.19.0 || >=22.12.0. The azure-cli:2.63.0 Docker image (Alpine 3.20) only provides Node.js 20.15.1 via apk, which doesn't satisfy that constraint — so the @rolldown/binding-linux-x64-musl native binding was skipped during npm ci, causing a startup error.

Two changes:

  1. The e2e test's linux-musl-x64 step now uses docker://node:22-alpine instead of docker://mcr.microsoft.com/azure-cli:2.63.0 — this step only needs a musl/Alpine Node.js environment, not azure-cli itself.
  2. The live test's Node.js setup step now installs from Alpine 3.21's repo (--repository https://dl-cdn.alpinelinux.org/alpine/v3.21/main) to get Node.js 22.x.


- name: Run Bicep E2E Tests (linux-musl-x64)
if: matrix.runtime.rid == 'linux-musl-x64'
uses: docker://mcr.microsoft.com/azure-cli:2.63.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change this. We explicitly use the azure-cli image to ensure Bicep CLI works when installed via Azure CLI.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! We should probably also add a comment not to change it (may help the next agent).

@brendandburns
Copy link
Copy Markdown
Member

@copilot please address comments about the base image in the gh action workflow

…dd do-not-change comment

Agent-Logs-Url: https://github.com/Azure/bicep/sessions/4c027788-deeb-4d6f-bfca-0528f8d38e2f

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

@copilot please address comments about the base image in the gh action workflow

Fixed in b7e0017. Reverted to docker://mcr.microsoft.com/azure-cli:2.63.0 and added a comment explaining why the image must not be changed. To get a Node.js version satisfying vitest 4.1.2's rolldown requirement (>=20.19.0), we now install Node.js from Alpine 3.21's repo — the same approach used in the live test job.

@brendandburns
Copy link
Copy Markdown
Member

@copilot looks like we may need to install sqllite libraries also.

…mbol errors

Agent-Logs-Url: https://github.com/Azure/bicep/sessions/09d8ed1d-fea3-4fe3-92de-f58608c9e316

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

@copilot looks like we may need to install sqllite libraries also.

Fixed in 17a57db. Node.js 22 from Alpine 3.21 dynamically links against sqlite3session_* symbols that aren't present in Alpine 3.20's sqlite (bundled in the azure-cli image). Added sqlite-libs to the apk add from the Alpine 3.21 repo in both the e2e test step and the live test Node.js setup step.

@brendandburns
Copy link
Copy Markdown
Member

@copilot looks like the linker errors are still there, please fix.

…om Alpine 3.21

Agent-Logs-Url: https://github.com/Azure/bicep/sessions/f50f96d3-e951-4a83-9b29-d4f5269afdea

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

@copilot looks like the linker errors are still there, please fix.

Fixed in 3d195da. The sqlite-libs package was already installed in the azure-cli image (from Alpine 3.20), so apk add silently skipped it without upgrading. Added --upgrade to the apk add command so that sqlite-libs (and nodejs/npm) are explicitly upgraded to the Alpine 3.21 versions, providing the sqlite3session_* symbols that Node.js 22 requires.

@brendandburns
Copy link
Copy Markdown
Member

@copilot please bump the azure-cli container image to the latest image.

…h to linux-x64 binary

Agent-Logs-Url: https://github.com/Azure/bicep/sessions/58e03664-7783-4ff8-8126-4bfcc8074591

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

@copilot please bump the azure-cli container image to the latest image.

Done in 07b3247. Both references bumped from 2.63.0 to 2.84.0 (the latest).

Note: azure-cli 2.63.0 was the last Alpine-based image; 2.64.0+ uses Azure Linux 3.0 (glibc). This required a few accompanying changes:

  • Package manager: apk addtdnf install -y nodejs22 npm
  • Binary: linux-musl-x64linux-x64 (musl binaries can't run on glibc)
  • E2e docker step: added a step to download the linux-x64 artifact before the docker container test
  • BICEP_CLI_DOTNET_RID updated to linux-x64 in both the e2e and live test steps

@brendandburns
Copy link
Copy Markdown
Member

@copilot ok, nevermind, I think that pinning the Azure cli version was on purpose, please revert the most recent changes and go back to the alpine version of things.

…pproach

Agent-Logs-Url: https://github.com/Azure/bicep/sessions/3b532efb-21ab-4d22-8ee9-f816c83b10fc

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

@copilot ok, nevermind, I think that pinning the Azure cli version was on purpose, please revert the most recent changes and go back to the alpine version of things.

Reverted in 25edc63. Back to mcr.microsoft.com/azure-cli:2.63.0 with apk add --no-cache --upgrade --repository https://dl-cdn.alpinelinux.org/alpine/v3.21/main nodejs npm sqlite-libs and linux-musl-x64 binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Automatically merge this PR dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants