Skip to content

Bump vitest from 4.0.18 to 4.1.2 in /src/Bicep.Cli.E2eTests #19301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 8 commits into
base: main
Choose a base branch
from
+592 −799
Open

Bump vitest from 4.0.18 to 4.1.2 in /src/Bicep.Cli.E2eTests #19301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c11aa97
Bump vitest from 4.0.18 to 4.1.2 in /src/Bicep.Cli.E2eTests
dependabot[bot] Mar 30, 2026
ed87fe5
fix ci: use node:22-alpine for musl e2e tests, use Alpine 3.21 nodejs…
Copilot Mar 30, 2026
c844736
fix ci: install icu-libs in node:22-alpine for .NET bicep CLI globali…
Copilot Mar 31, 2026
b7e0017
fix ci: revert to azure-cli image, install nodejs from Alpine 3.21, a…
Copilot Apr 1, 2026
17a57db
fix ci: install sqlite-libs from Alpine 3.21 to resolve Node.js 22 sy…
Copilot Apr 1, 2026
3d195da
fix ci: add --upgrade flag to apk add to force sqlite-libs upgrade fr…
Copilot Apr 2, 2026
07b3247
fix ci: bump azure-cli from 2.63.0 to 2.84.0 (Azure Linux 3.0), switc…
Copilot Apr 2, 2026
25edc63
revert: undo azure-cli 2.84.0 bump, restore azure-cli:2.63.0 Alpine a…
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,10 +668,14 @@ jobs:

- name: Run Bicep E2E Tests (linux-musl-x64)
if: matrix.runtime.rid == 'linux-musl-x64'
# DO NOT change this image - we use the azure-cli image intentionally to ensure
# that Bicep CLI works correctly when installed via Azure CLI. The azure-cli image
# is based on Alpine Linux (musl libc) and already includes the ICU libraries
# required by the .NET Bicep CLI binary.
uses: docker://mcr.microsoft.com/azure-cli:2.63.0
Copy link
Copy Markdown
Contributor

@shenglol shenglol Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change this. We explicitly use the azure-cli image to ensure Bicep CLI works when installed via Azure CLI.

Copy link
Copy Markdown
Member

@majastrz majastrz Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! We should probably also add a comment not to change it (may help the next agent).

with:
entrypoint: sh
args: -c "set -eu && apk add --no-cache nodejs npm && node -v && npm -v && npm ci --prefix ./src/Bicep.Cli.E2eTests && npm test --prefix ./src/Bicep.Cli.E2eTests"
args: -c "set -eu && apk add --no-cache --upgrade --repository https://dl-cdn.alpinelinux.org/alpine/v3.21/main nodejs npm sqlite-libs && node -v && npm -v && npm ci --prefix ./src/Bicep.Cli.E2eTests && npm test --prefix ./src/Bicep.Cli.E2eTests"
env:
BICEP_CLI_DOTNET_RID: ${{ matrix.runtime.rid }}
BICEP_CLI_EXECUTABLE: ../../../Bicep.Cli.E2eTests/src/temp/bicep-cli/bicep
Expand Down Expand Up @@ -863,7 +867,7 @@ jobs:
- name: Setup Node.js
run: |
set -eu
apk add --no-cache nodejs npm
apk add --no-cache --upgrade --repository https://dl-cdn.alpinelinux.org/alpine/v3.21/main nodejs npm sqlite-libs
node -v
npm -v

Expand Down
Loading
Loading