Skip to content

Conversation

@jwtty
Copy link
Contributor

@jwtty jwtty commented Jan 6, 2025

Description of your changes

  1. Add additionalPrinterColumns for clusterStagedUpdateRun and clusterApprovalRequest objects.
  2. Add validations in updateRun name length and stageName to ensure ApprovalRequest name valid .
  3. Update the examples to use the v1beta1 APIs.

The get command outputs now look like:

kubectl get clusterstagedupdaterun
NAME          PLACEMENT           RESOURCE-SNAPSHOT               POLICY-SNAPSHOT        INITIALIZED   SUCCEEDED   AGE
example-run   example-placement   example-placement-0-snapshot   example-placement-7   True          True        13m

kubectl get clsuterstagedupdaterun -owide
NAME          PLACEMENT           RESOURCE-SNAPSHOT               STRATEGY           POLICY-SNAPSHOT        INITIALIZED   SUCCEEDED   AGE
example-run   example-placement   example-placement-0-snapshot   example-strategy   example-placement-7   True          True        3m47s

kubectl get clusterapprovalrequests
NAME                     UPDATE-RUN     STAGE        APPROVED   AGE
example-run-canary       example-run   canary       True       12m
example-run-production   example-run   production   True       11m

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@jwtty jwtty force-pushed the stagerun-apiexample branch 2 times, most recently from e0058dc to e4822b7 Compare January 9, 2025 02:57
@jwtty jwtty changed the title chore: improve clusterStageUpdateRun UI and examples interface: add more stagedUpdateRun additionalPrintColumns Jan 9, 2025
@jwtty jwtty force-pushed the stagerun-apiexample branch from b5d3d56 to 5e0e36d Compare January 14, 2025 08:37
@jwtty jwtty changed the title interface: add more stagedUpdateRun additionalPrintColumns interface: improve ClusterStagedUpdateRun APIs Jan 14, 2025
@jwtty jwtty force-pushed the stagerun-apiexample branch from 5e0e36d to 71a9475 Compare January 16, 2025 00:38
@jwtty jwtty merged commit 7dfc13c into Azure:main Jan 16, 2025
12 checks passed
@jwtty jwtty deleted the stagerun-apiexample branch January 16, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants