feat: add svc export trackability #1061
Merged
ryanzhang-oss merged 6 commits intoAzure:mainfrom Mar 13, 2025
Merged
Conversation
britaniar
force-pushed
the
svcExportTrackability
branch
5 times, most recently
from
87efd16 to
e49aff2
Compare
Contributor
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
this should be separated into two PRs, one just for upgrade controller runtime and the other for serviceExport check
Contributor
Author
|
upgrade controller runtime changes are addressed in #1067 (will need to be merged before this) |
britaniar
force-pushed
the
svcExportTrackability
branch
from
9b3574b to
593b6b3
Compare
britaniar
force-pushed
the
svcExportTrackability
branch
from
593b6b3 to
c47b06c
Compare
zhiying-lin
reviewed
Mar 6, 2025
zhiying-lin
reviewed
Mar 7, 2025
britaniar
force-pushed
the
svcExportTrackability
branch
from
74d71eb to
6b43ca2
Compare
zhiying-lin
reviewed
Mar 12, 2025
ryanzhang-oss
approved these changes
Mar 13, 2025
zhiying-lin
reviewed
Mar 13, 2025
| if err != nil { | ||
| klog.V(2).InfoS("ServiceExport has invalid weight", "serviceExport", svcExportObj, "error", err) | ||
| return ManifestProcessingAvailabilityResultTypeFailed, err | ||
| klog.Errorf(err.Error(), "ServiceExport has invalid weight", "serviceExport", svcExportObj) |
Contributor
There was a problem hiding this comment.
klog.Errorf(err, "ServiceExport has invalid weight", "serviceExport", svcExportObj)
you don't need to call the err.Error(). the klog will print out the error message automatically.
| return ManifestProcessingAvailabilityResultTypeNotYetAvailable, nil | ||
| } | ||
|
|
||
| // Validate annotation weight. Updating the annotation won't change the object generation, |
| klog.V(2).InfoS("ServiceExport has invalid weight", "serviceExport", svcExportObj, "error", err) | ||
| return ManifestProcessingAvailabilityResultTypeFailed, err | ||
| klog.Errorf(err.Error(), "ServiceExport has invalid weight", "serviceExport", svcExportObj) | ||
| return ManifestProcessingAvailabilityResultTypeNotYetAvailable, err |
Contributor
There was a problem hiding this comment.
we should not return the error here. no need to retry.
Sorry, it was missed before :(
1 task
zhiying-lin
added a commit
to zhiying-lin/fleet
that referenced
this pull request
Mar 20, 2025
This reverts commit 22dc1a0.
1 task
ryanzhang-oss
pushed a commit
that referenced
this pull request
Mar 20, 2025
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Apr 22, 2025
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Apr 22, 2025
* Revert "address comments to fix bug (Azure#1080)" This reverts commit 9a376db. * Revert "feat: add svc export trackability (Azure#1061)" This reverts commit 22dc1a0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer