Skip to content

Add support for ScaledJob #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidgamero merged 7 commits into from
Jul 17, 2025
Merged

Add support for ScaledJob #436

davidgamero merged 7 commits into from
Jul 17, 2025

Conversation

@benjaminbob21
Copy link
Contributor

@benjaminbob21 benjaminbob21 commented Jul 15, 2025

This PR adds comprehensive support for KEDA ScaledJob resources to the k8s-deploy GitHub Action, addressing feature request #277. ScaledJob resources are now treated as first-class workload entities with proper handling of their nested structure for image pull secrets, labels, and deployment strategies.

Key Changes

  • Added ScaledJob to core type system in KubernetesWorkload, WORKLOAD_TYPES, and DEPLOYMENT_TYPES
  • Updated manifestPullSecretUtils.ts and manifestSpecLabelUtils.ts to handle ScaledJob's nested jobTemplate structure (similar to CronJob)
  • Modified getReplicaCount to return 0 for ScaledJob since replicas are managed by KEDA
  • Added dedicated test file and manifest for ScaledJob functionality

@benjaminbob21 benjaminbob21 self-assigned this Jul 15, 2025
@benjaminbob21 benjaminbob21 marked this pull request as ready for review July 16, 2025 17:00
@benjaminbob21 benjaminbob21 requested a review from a team as a code owner July 16, 2025 17:00
@benjaminbob21 benjaminbob21 added enhancement Feature request/improved experience and removed do not merge labels Jul 16, 2025
Tatsinnit
Tatsinnit reviewed Jul 17, 2025
View reviewed changes
Tatsinnit
Tatsinnit reviewed Jul 17, 2025
View reviewed changes
Tatsinnit
Tatsinnit reviewed Jul 17, 2025
View reviewed changes
Tatsinnit
Tatsinnit approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kind ping!! Please, Let’s also get @bosesuneha and @davidgamero eyes for review here as well, thanks

davidgamero
davidgamero approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit 4755eab into Azure:main Jul 17, 2025
13 checks passed
@maddox-214 maddox-214 mentioned this pull request Jul 17, 2025
Closed
@bosesuneha bosesuneha mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamero davidgamero davidgamero approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

Assignees

@benjaminbob21 benjaminbob21

Labels

enhancement Feature request/improved experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjaminbob21 @davidgamero @Tatsinnit