-
Notifications
You must be signed in to change notification settings - Fork 146
[iOS SDK] Remove MFA and JIT Private Preview tag #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSAL/test/unit/MSALPublicClientApplicationTests.m needs to be changed also I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, worth to remove this one:
microsoft-authentication-library-for-objc/MSAL/src/native_auth/MSALNativeAuthLogMessage.swift
Line 28 in 46c389d
static let privatePreviewLog = |
That test is not ours, not sure what it is about but quite sure we didn't write it and we shouldn't touch it :D |
We could remove it indeed, but we might it reuse it in the future soon for the new features going in Private Preview. |
Proposed changes
As we are going into public preview with this feature, I have removed the MFA and JIT Private Preview tag and logs
Type of change
Risk
Additional information