Skip to content

[iOS SDK] Remove MFA and JIT Private Preview tag #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

spetrescu84
Copy link
Contributor

Proposed changes

As we are going into public preview with this feature, I have removed the MFA and JIT Private Preview tag and logs

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@spetrescu84 spetrescu84 requested review from a team as code owners July 16, 2025 09:47
@spetrescu84 spetrescu84 changed the title Remove MFA and JIT Private Preview tag [iOS SDK] Remove MFA and JIT Private Preview tag Jul 16, 2025
Copy link

@mustafamizrak mustafamizrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSAL/test/unit/MSALPublicClientApplicationTests.m needs to be changed also I guess.

@spetrescu84 spetrescu84 requested a review from a team July 16, 2025 10:14
@spetrescu84 spetrescu84 self-assigned this Jul 16, 2025
Copy link

@mustafamizrak mustafamizrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, worth to remove this one:

@spetrescu84
Copy link
Contributor Author

MSAL/test/unit/MSALPublicClientApplicationTests.m needs to be changed also I guess.

That test is not ours, not sure what it is about but quite sure we didn't write it and we shouldn't touch it :D

@spetrescu84
Copy link
Contributor Author

Also, worth to remove this one:

We could remove it indeed, but we might it reuse it in the future soon for the new features going in Private Preview.
@nilo-ms what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants