Skip to content

[iOS SDK] Remove MFA and JIT Private Preview tag #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## [TBC]
* Removed warnings about Private Preview for Email OTP MFA and Register Strong Auth in native authentication (#2670)

## [2.2.0]
* Make native auth MFA feature more backward compatible (#2645)

Expand Down
2 changes: 1 addition & 1 deletion MSAL/IdentityCore
Submodule IdentityCore updated 0 files
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ extension RegisterStrongAuthBaseState {
func requestChallengeInternal(authMethod: MSALAuthMethod,
verificationContact: String?) async -> MSALNativeAuthJITControlling.JITRequestChallengeControllerResponse {
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
MSALNativeAuthLogger.log(level: .info, context: context, format: "RegisterStrongAuth, Request Challenge")
return await controller.requestJITChallenge(continuationToken: continuationToken,
authMethod: authMethod,
Expand All @@ -39,7 +38,6 @@ extension RegisterStrongAuthVerificationRequiredState {

func submitChallengeInternal(challenge: String) async -> MSALNativeAuthJITControlling.JITSubmitChallengeControllerResponse {
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
MSALNativeAuthLogger.log(level: .info, context: context, format: "RegisterStrongAuth, Submit Challenge")
guard inputValidator.isInputValid(challenge) else {
MSALNativeAuthLogger.log(level: .error, context: context, format: "RegisterStrongAuth, invalid challenge")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public class RegisterStrongAuthBaseState: MSALNativeAuthBaseState {
public class RegisterStrongAuthState: RegisterStrongAuthBaseState {

/// Requests the server to send the challenge to the default authentication method.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameters:
/// - parameters: Parameters used to challenge an authentication method
/// - delegate: Delegate that receives callbacks for the operation.
Expand Down Expand Up @@ -91,7 +90,6 @@ public class RegisterStrongAuthVerificationRequiredState: RegisterStrongAuthBase
}

/// Submits the challenge to verify the authentication method selected.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameters:
/// - challenge: Verification challenge that the user supplies.
/// - delegate: Delegate that receives callbacks for the operation.
Expand All @@ -109,7 +107,6 @@ public class RegisterStrongAuthVerificationRequiredState: RegisterStrongAuthBase
}

/// Requests the server to send the challenge to the default authentication method.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameters:
/// - parameters: Parameters used to challenge an authentication method
/// - delegate: Delegate that receives callbacks for the operation.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import Foundation
extension MFABaseState {
func requestChallengeInternal(authMethod: MSALAuthMethod?) async -> MSALNativeAuthMFAControlling.MFARequestChallengeControllerResponse {
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, request challenge")
return await controller.requestChallenge(
continuationToken: continuationToken,
Expand All @@ -42,7 +41,6 @@ extension MFABaseState {
extension MFARequiredState {
func getAuthMethodsInternal() async -> MSALNativeAuthMFAControlling.MFAGetAuthMethodsControllerResponse {
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, get authentication methods")
return await controller.getAuthMethods(
continuationToken: continuationToken,
Expand All @@ -54,7 +52,6 @@ extension MFARequiredState {

func submitChallengeInternal(challenge: String) async -> MSALNativeAuthMFAControlling.MFASubmitChallengeControllerResponse {
let context = MSALNativeAuthRequestContext(correlationId: correlationId)
MSALNativeAuthLogger.log(level: .warning, context: context, format: MSALNativeAuthLogMessage.privatePreviewLog)
MSALNativeAuthLogger.log(level: .info, context: context, format: "MFA, submit challenge")
guard inputValidator.isInputValid(challenge) else {
MSALNativeAuthLogger.log(level: .error, context: context, format: "MFA, invalid challenge")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ import Foundation
public class AwaitingMFAState: MFABaseState {

/// Requests the server to send the challenge to the default authentication method.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameter delegate: Delegate that receives callbacks for the operation.
public func requestChallenge(delegate: MFARequestChallengeDelegate) {
baseRequestChallenge(authMethod: nil, delegate: delegate)
Expand Down Expand Up @@ -103,7 +102,6 @@ public class MFARequiredState: MFABaseState {
}

/// Requests the server to send the challenge to the specified auth method or the default one.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameters:
/// - authMethod: Optional. The authentication method you want to use for sending the challenge
/// - delegate: Delegate that receives callbacks for the operation.
Expand All @@ -112,7 +110,6 @@ public class MFARequiredState: MFABaseState {
}

/// Requests the available MFA authentication methods.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameter delegate: Delegate that receives callbacks for the operation.
public func getAuthMethods(delegate: MFAGetAuthMethodsDelegate) {
Task {
Expand All @@ -132,7 +129,6 @@ public class MFARequiredState: MFABaseState {
}

/// Submits the MFA challenge to the server for verification.
/// - Warning: ⚠️ this API is experimental. It may be changed in the future without notice. Do not use in production applications.
/// - Parameters:
/// - challenge: Verification challenge that the user supplies.
/// - delegate: Delegate that receives callbacks for the operation.
Expand Down
Loading