-
Notifications
You must be signed in to change notification settings - Fork 152
Add external texture tests #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
15f6f78 to
50c538f
Compare
Fix broken move semantics in ExternalTexture Pass command line arguments to google test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds external texture tests to the BabylonNative codebase, introducing platform-specific test utilities for creating and destroying textures across Metal, D3D11, D3D12, and OpenGL backends.
Key changes include:
- Added comprehensive external texture tests with platform-specific texture creation utilities
- Fixed lambda capture semantics by adding
mutablekeyword wherestd::moveis used in lambda bodies - Refactored test infrastructure to support command-line arguments and consolidated test entry points
- Removed Android build artifacts and updated bgfx debug annotation configuration
Reviewed changes
Copilot reviewed 38 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Apps/UnitTests/Source/Tests.ExternalTexture.cpp | New test file for external texture construction and async operations |
| Apps/UnitTests/Source/Utils*.cpp | Platform-specific texture creation/destruction utilities for D3D11, D3D12, Metal, and OpenGL |
| Apps/UnitTests/Source/App*.cpp | Refactored main entry points to accept argc/argv parameters |
| Apps/UnitTests/CMakeLists.txt | Updated to include external texture tests and platform-specific utilities |
| Plugins/ExternalTexture/Source/ExternalTexture_Shared.h | Fixed lambda captures by adding mutable keyword for move operations |
| Core/Graphics/Source/DeviceImpl_Metal.cpp | Refactored Metal device type usage to use proper Objective-C id syntax |
| Dependencies/CMakeLists.txt | Moved BGFX_CONFIG_DEBUG_ANNOTATION setting to compile definitions to fix D3D12 access violation |
| CMakeLists.txt | Updated JsRuntimeHost dependency git tag |
| Android/* | Removed entire Android build infrastructure |
Files not reviewed (1)
- Apps/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
Apps/UnitTests/Source/App_X11.cpp:19
- Extra closing parenthesis in the function signature. The function should be declared as
int main(int argc, char* argv[])without the extra closing parenthesis.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update Install/Test again.
No description provided.