Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
aabe7ad
feat: upgrade to angular 20 and migrate to standalone architecture
tcorral Nov 16, 2025
4e82f15
fix: fix issues in ci/cd
tcorral Nov 16, 2025
4ab205b
feat(app-component): add styles to do not overflow
tcorral Nov 16, 2025
4d4a2f0
fix: fix browswer issues
tcorral Nov 16, 2025
665d5ce
feat: fix tsc issues
tcorral Nov 16, 2025
f101812
fix: resolve conflicts
Nov 26, 2025
efcb748
chore: update visual transaction snapshots for Chrome on Linux
Nov 26, 2025
5c124e6
fix: update test setup and component spec for improved testing enviro…
Nov 26, 2025
8dd66f3
fix: unit tests failing
Nov 26, 2025
357275a
fix: unit test issues
Nov 26, 2025
0c162b4
fix: enhance test setup by adding router provider for user context an…
Nov 26, 2025
87afd03
fix: refactor user context component tests to utilize injected router…
Nov 26, 2025
e8c0246
fix: unit test issues
Nov 26, 2025
93bbc4f
chore: applying code review suggestions
tcorral Nov 27, 2025
b1d129a
chore: applying code review suggestions
tcorral Nov 27, 2025
6ad16c3
chore: applying code review suggestions
tcorral Nov 27, 2025
c203e0b
chore: applying code review suggestions
tcorral Nov 27, 2025
2c4ffd8
chore: applying code review suggestions
tcorral Nov 27, 2025
4db1903
chore: applying code review suggestions
tcorral Nov 27, 2025
4f80f0e
chore: applying code review suggestions
tcorral Nov 27, 2025
3d9c362
chore: applying code review suggestions
tcorral Nov 27, 2025
abc7b60
chore: applying code review suggestions
tcorral Nov 27, 2025
9d63e2f
chore: applying code review suggestions
tcorral Nov 27, 2025
e99b04f
chore: applying code review suggestions
tcorral Nov 27, 2025
735bdce
chore: applying code review suggestions
tcorral Nov 27, 2025
83ea6a4
chore: applying code review suggestions
tcorral Nov 27, 2025
10761c8
chore: apply code review suggestions
Nov 27, 2025
fba0b96
chore: apply code review suggestions
Nov 27, 2025
77d5331
chore: apply code review suggestions
Nov 27, 2025
4a9a899
chore: apply code review suggestions
Nov 27, 2025
712dec0
chore: apply code review suggestions
Nov 27, 2025
21f2a07
chore: apply code review suggestions
Nov 27, 2025
958e1c5
chore: apply suggested changes in code review
Nov 27, 2025
df40be6
chore: apply suggested changes in code review
Nov 27, 2025
6dac881
chore: apply suggested changes in code review
Nov 27, 2025
837983c
chore: apply suggested changes in code review
Nov 27, 2025
e103e46
chore: apply suggested changes in code review
Nov 27, 2025
4a23f34
debug: remove
Nov 27, 2025
f18e5e4
chore: fix build after refactoring to remove NgModules
Nov 27, 2025
78922c5
chore: fix build after refactoring to remove NgModules
Nov 27, 2025
e4fe236
chore: fix build after refactoring to remove NgModules
Nov 27, 2025
58f37b1
chore: fix build after refactoring to remove NgModules
Nov 27, 2025
8e81d9a
chore: apply suggested changes in pull request
Nov 28, 2025
0e8483d
chore: apply suggested changes in pull request
Nov 28, 2025
ed0ed55
chore: apply suggested changes in pull request
Nov 28, 2025
86affef
chore: apply suggested changes in pull request
Nov 28, 2025
ab36d83
chore: apply suggested changes in pull request
Nov 28, 2025
780d624
chore: apply suggested changes in pull request
Nov 28, 2025
9d0fc1d
chore: apply suggested changes in pull request
Nov 28, 2025
eb3b01a
chore: apply suggested changes in pull request
Nov 28, 2025
52e4702
chore: apply suggested changes in pull request
Nov 28, 2025
bac14e4
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
b63e1f0
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
a644dbb
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
39ac35a
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
7009c32
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
28b3a3a
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
d0c495a
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
a7653af
chore: adjust documentation to be checked against implementation code
Nov 28, 2025
e8ff6a8
chore: apply suggested changes in pull request
Dec 1, 2025
8565dcc
fix:build step failing
Dec 1, 2025
4a9f705
fix:build step failing
Dec 1, 2025
9b3d750
fix: format
Dec 1, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/actions/node-step/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ runs:
env:
NODE_AUTH_TOKEN: ${{ inputs.npm-auth-token }}
NODE_EMAIL: ${{ inputs.npm-email }}
continue-on-error: true


- name: Upload NPM Log
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ jobs:
env:
NPM_BB_TOKEN: ${{ secrets.NPM_BB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_EMAIL: ${{ secrets.NPM_EMAIL }}
NPM_EMAIL: ${{ secrets.NODE_EMAIL }}
with:
npm-auth-token: ${{ secrets.NPM_BB_TOKEN }}
npm-email: ${{ secrets.NPM_EMAIL }}
npm-email: ${{ secrets.NODE_EMAIL }}

- name: Cache npm dependencies
uses: actions/cache@v4
Expand All @@ -75,7 +75,6 @@ jobs:
playwright:
name: "Playwright Tests"
runs-on: ubuntu-latest
continue-on-error: true
needs: get-playwright-version
container:
image: mcr.microsoft.com/playwright:v${{ needs.get-playwright-version.outputs.version }}
Expand Down Expand Up @@ -114,11 +113,9 @@ jobs:
run: |
apt-get update
apt-get install -y default-jre
continue-on-error: true

- name: Generate Allure Report
run: npm run report-generate
continue-on-error: true

- name: Upload Playwright Report
if: ${{ !cancelled() }}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion apps/golden-sample-app/jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable */
export default {
displayName: 'golden-sample-app',
preset: '../../jest.preset.js',
Expand Down
11 changes: 3 additions & 8 deletions apps/golden-sample-app/src/app/app-routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,12 @@ export const APP_ROUTES: Routes = [
},
{
path: 'select-context',
loadChildren: () =>
import('./user-context/user-context.module').then(
(m) => m.UserContextModule
),
loadComponent: () => import('./user-context/user-context.component'),
canActivate: [AuthGuard],
},
{
path: 'error',
loadChildren: () =>
import('./error-page/error-page.module').then((m) => m.ErrorPageModule),
loadComponent: () => import('./error-page/error-page.component'),
},
TRANSFER_ROUTE,
ACH_POSITIVE_PAY_ROUTE,
Expand All @@ -33,7 +29,6 @@ export const APP_ROUTES: Routes = [
{
path: '**',
pathMatch: 'full',
loadChildren: () =>
import('./error-page/error-page.module').then((m) => m.ErrorPageModule),
loadComponent: () => import('./error-page/error-page.component'),
},
];
2 changes: 1 addition & 1 deletion apps/golden-sample-app/src/app/app.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
</div>

<!-- Navigation Items-->
<app-navigation-menu />
<bb-dynamic-navigation-menu />

<!-- Topbar Content Area (a.k.a. Right Topbar Area) -->
<div class="bb-layout__topbar-content-area">
Expand Down
6 changes: 5 additions & 1 deletion apps/golden-sample-app/src/app/app.component.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.main-content {
padding: 20px;
}
}
app-navigation-menu {
max-width: 70%;
overflow: auto;
}
7 changes: 6 additions & 1 deletion apps/golden-sample-app/src/app/app.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { HttpClientTestingModule } from '@angular/common/http/testing';
import { RouterTestingModule } from '@angular/router/testing';
import { ActivityMonitorService, AuthService } from '@backbase/identity-auth';
import { LOCALES_LIST, LocalesService } from '@backbase/shared/util/app-core';
import {
LOCALES_LIST,
LocalesService,
NAVIGATION_MENU_CONFIG,
} from '@backbase/shared/util/app-core';
import { LayoutService } from '@backbase/ui-ang/layout';
import { OAuthService } from 'angular-oauth2-oidc';
import { of } from 'rxjs';
Expand Down Expand Up @@ -49,6 +53,7 @@ describe('AppComponent', () => {
{ provide: AuthService, useValue: mockAuthService },
{ provide: LocalesService, useValue: mockLocalesService },
{ provide: LOCALES_LIST, useValue: mockLocalesList },
{ provide: NAVIGATION_MENU_CONFIG, useValue: [] },
],
schemas: [NO_ERRORS_SCHEMA],
}).compileComponents();
Expand Down
12 changes: 6 additions & 6 deletions apps/golden-sample-app/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,25 @@ import {
LogoutTrackerEvent,
Tracker,
} from '@backbase/foundation-ang/observability';
import { ActivityMonitorModule } from '@backbase/shared/feature/auth';
import { ActivityMonitorComponent } from '@backbase/shared/feature/auth';
import { DynamicNavigationMenuComponent } from '@backbase/shared/feature/navigation-menu';
import { IconModule } from '@backbase/ui-ang/icon';
import { LayoutService } from '@backbase/ui-ang/layout';
import { LogoModule } from '@backbase/ui-ang/logo';
import { OAuthService } from 'angular-oauth2-oidc';
import { LocaleSelectorComponent } from './locale-selector/locale-selector.component';
import { NavigationMenuModule } from './navigation-menu/navigation-menu.module';
import { ThemeSwitcherModule } from './theme-switcher/theme-switcher.component.module';
import { ThemeSwitcherComponent } from './theme-switcher/theme-switcher.component';

@Component({
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.scss'],
imports: [
ActivityMonitorModule,
ActivityMonitorComponent,
CommonModule,
LogoModule,
NavigationMenuModule,
ThemeSwitcherModule,
DynamicNavigationMenuComponent,
ThemeSwitcherComponent,
LocaleSelectorComponent,
IconModule,
RouterOutlet,
Expand Down
20 changes: 20 additions & 0 deletions apps/golden-sample-app/src/app/app.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,20 @@ import { environment } from '../environments/environment';
import { APP_ROUTES } from './app-routes';
import { AppErrorHandler } from './app.error-handler';
import { OAuthStorage } from 'angular-oauth2-oidc';
import { provideActivityMonitor } from '@backbase/shared/feature/auth';
import {
NAVIGATION_MENU_CONFIG,
NavigationMenuItem,
composeNavigationTree,
} from '@backbase/shared/util/app-core';
import {
NAVIGATION_BUNDLE,
NAVIGATION_GROUPS,
} from './navigation-menu/navigation-menu.config';

function navigationTreeConfig(): NavigationMenuItem[] {
return composeNavigationTree(NAVIGATION_BUNDLE, NAVIGATION_GROUPS);
}

const sharedJourneyConfig: SharedJourneyConfiguration = {
designSlimMode: false,
Expand Down Expand Up @@ -70,11 +84,17 @@ export const appConfig: ApplicationConfig = {
// Other providers here are common to all environments
{ provide: OAuthStorage, useValue: localStorage },
provideLocales(['en-US', 'nl-NL']),
...provideActivityMonitor(),
provideRouter(APP_ROUTES, withComponentInputBinding()),
provideAnimations(),
provideHttpClient(withInterceptorsFromDi()),
provideEntitlements(),

{
provide: NAVIGATION_MENU_CONFIG,
useFactory: navigationTreeConfig,
},

{
provide: SHARED_JOURNEY_CONFIG,
useValue: sharedJourneyConfig,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import { HttpErrorResponse } from '@angular/common/http';
import { Component, inject } from '@angular/core';
import { Router } from '@angular/router';
import { ErrorCommonStateModule } from '@backbase/ui-ang/common-error-state';

@Component({
selector: 'app-error-page',
templateUrl: './error-page.component.html',
standalone: false,
imports: [ErrorCommonStateModule],
})
export class ErrorPageComponent {
export default class ErrorPageComponent {
private readonly router: Router = inject(Router);
public error =
this.router.getCurrentNavigation()?.extras.state?.['error'] ??
Expand Down
21 changes: 0 additions & 21 deletions apps/golden-sample-app/src/app/error-page/error-page.module.ts

This file was deleted.

This file was deleted.

This file was deleted.

68 changes: 0 additions & 68 deletions apps/golden-sample-app/src/app/sample-standalone.component.ts

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Component, inject, Input } from '@angular/core';
import { DropdownMenuModule } from '@backbase/ui-ang/dropdown-menu';
import { ThemeManagerService } from './theme-service';

@Component({
selector: 'app-theme-switcher',
templateUrl: './theme-switcher.component.html',
standalone: false,
imports: [DropdownMenuModule],
})
export class ThemeSwitcherComponent {
private readonly themeManagerService: ThemeManagerService =
Expand Down
Loading
Loading