-
Notifications
You must be signed in to change notification settings - Fork 26
feat: upgrade to angular 20 and migrate to standalone architecture #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d user accounts components
… for navigation assertions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades the application from Angular 19 to Angular 20 and migrates the architecture from NgModule-based to standalone components. This is a significant modernization effort that aligns with Angular's recommended architectural patterns and improves code maintainability, bundle size, and lazy loading capabilities.
Key Changes:
- Upgraded Angular and related dependencies from v19.2.0 to v20.3.0
- Migrated components from NgModule-based to standalone architecture
- Converted route modules to use
loadComponentpattern for lazy loading - Introduced provider functions (
provideTransferJourney,provideTransactionsJourney, etc.) for standalone apps
Reviewed changes
Copilot reviewed 55 out of 58 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Upgraded Angular to 20.3.0, NgRx to 20.1.0, Nx to 22.0.3, and related dependencies |
| libs/transfer-journey/* | Migrated to standalone with new shell config and provider functions |
| libs/transactions-journey/* | Migrated to standalone with lazy-loaded components and provider pattern |
| libs/shared/feature/* | Converted shared components (navigation-menu, view-wrapper, user-context) to standalone |
| apps/golden-sample-app/* | Updated app components to standalone and routing to use loadComponent |
| libs/journey-bundles/* | Updated journey bundles to support standalone architecture |
| test files | Updated test configurations for standalone components and fixed deprecated Jest matchers |
Critical Issues Found:
- Several components missing
standalone: trueproperty despite having imports arrays - Incorrect injection token usage (string literal instead of InjectionToken)
- TypeScript version appears to be downgraded instead of upgraded
- Overly specific peer dependency versions in library package.json files
- Duplicate provider instances in component-level providers
- Import path issues for relocated tokens
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.