Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
8cd4455
imdreader et al removed
amruthesht Feb 19, 2025
95a70fa
Chnages to remove IMDReader
amruthesht Mar 12, 2025
fa25049
minimalReader for tests
amruthesht Mar 18, 2025
3c72675
Code Changes
amruthesht Apr 2, 2025
72fa772
Minor changes
amruthesht Apr 2, 2025
9e906f0
Minimal reader and corresponding test-suite clean up
amruthesht Apr 9, 2025
fb0d1b7
Chore: `n_atoms` extracted using `mdanalysis`
amruthesht Apr 9, 2025
5485680
Merge branch 'main' into imdreader-split
orbeckst Apr 9, 2025
bcf6f7c
Merge branch 'main' into imdreader-split
orbeckst Apr 9, 2025
b2bb3c9
Added: `copy` method to `IMDFrame`
amruthesht Apr 10, 2025
db10481
Minor changes
amruthesht Apr 15, 2025
f387059
Fix: dimensions in IMDFrame
amruthesht Apr 15, 2025
4769c4f
Changes: Removed tests for `dt`
amruthesht Apr 16, 2025
4554ad9
Fix: Change how box dimensions are stored
amruthesht Apr 16, 2025
859b0fe
Fix: `close()` method and fix `wait`-related tests
amruthesht Apr 16, 2025
a0cc914
Change: using deepcopy instead and dimensions created by assignment
amruthesht Apr 28, 2025
2afdb82
Fix: minimalReader process_stream behavior to change IMD_WAIT effect
amruthesht May 13, 2025
17fadae
Fix: update NAMD input frequency
amruthesht May 14, 2025
e8e4fc6
Modify/Fix: tests for GROMACS/LAMMPS
amruthesht May 27, 2025
b4ff92e
Fix: GROMACS/LAMMPS tests for step
amruthesht May 28, 2025
b8a7cad
Cleanup: Fix small issues in manual tests
amruthesht Jun 2, 2025
a108f42
Update docs and imports
jaclark5 May 5, 2025
abe3488
Update imports
jaclark5 May 5, 2025
3d4c6a1
Fix: update NAMD steps further
amruthesht May 14, 2025
4340015
Fix import
jaclark5 May 24, 2025
f310986
Fix: PR #64 merge conflicts
amruthesht Jun 2, 2025
dfeee77
Add: `minimalReader` usage
amruthesht Jun 2, 2025
f2e2e48
Chore: fix dependencies for examples
amruthesht Jun 3, 2025
5b6854b
Change: `minimalReader` chnaged to `MinimalReader`
amruthesht Jun 3, 2025
c29c57f
Doc: `MinimalReader` doc update for class
amruthesht Jun 3, 2025
1fa261b
Fix: `pop_full_imdframe` doc comments
amruthesht Jun 3, 2025
c12b91d
Chore: Remove example dependencies installation
amruthesht Jun 3, 2025
7bac503
Fix: indentation `index.rst`
amruthesht Jun 3, 2025
12ec780
Chore: Minor clean ups and changes
amruthesht Jun 19, 2025
f1a1a6f
Change: `minimalreader`-free examples in `usage.rst` and `examples` d…
amruthesht Jun 23, 2025
3c70b6e
Fix: Lammps topology settings for MDA under examples
amruthesht Jun 23, 2025
282c3ed
Fix: remove `process_stream` under `test_wait_after_disconnect`
amruthesht Jun 23, 2025
17e4f71
Doc: add doc_string for `parse_host_port()`
amruthesht Jun 23, 2025
382fc49
Add: Unit tests for `parse_host_port`
amruthesht Jun 23, 2025
4846157
Add: utils test to GH-CI
amruthesht Jun 23, 2025
f34eac6
parse mdp/inp for dt
ljwoods2 Jun 24, 2025
73556cc
Merge branch 'main' into test_dt
orbeckst Jun 24, 2025
7662f5b
Merge branch 'main' into imdreader-split
orbeckst Jun 24, 2025
ebef779
Merge branch 'main' into imdreader-split
orbeckst Jun 24, 2025
56d18ef
Update: `.toml` to fix dependencies
amruthesht Jun 25, 2025
59b4306
Update: CHANGELOG
amruthesht Jun 25, 2025
a329edf
Merge branch 'imdreader-split' into test_dt
ljwoods2 Jun 25, 2025
b5bd892
Merge pull request #71 from Becksteinlab/test_dt
ljwoods2 Jun 25, 2025
c6d52c2
change "minimalreader" to MinimalReader
ljwoods2 Jun 25, 2025
6750a39
fix erroneous merge changes from test_dt branch
ljwoods2 Jun 25, 2025
d8bbab9
undo black diffs for test_dt changes
ljwoods2 Jun 25, 2025
f1336b2
ReFormat: all files
amruthesht Jun 25, 2025
7c6cb4b
Add: NAMD tests for `dt`
amruthesht Jun 25, 2025
45c4a1d
Chore: Minor cleanup and add checks for tests
amruthesht Jun 25, 2025
158bb4c
remove all assertion guards
ljwoods2 Jun 27, 2025
8848d4d
Chore: Minor cleanups
amruthesht Jun 27, 2025
5d063e0
Merge branch 'main' into imdreader-split
orbeckst Jun 27, 2025
0f1f62b
Update: Examples to output simple info
amruthesht Jun 27, 2025
cdbbd1c
Add: Added Amruthesh as contributor/maintainer
amruthesht Jun 27, 2025
2eb3425
Apply suggestions from code review
orbeckst Jun 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions .github/workflows/gh-ci.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if coverage is correctly reported but this may be something to figure out once this is merged.

Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,15 @@ jobs:
needs: environment-config
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [macOS-latest, ubuntu-latest]
python-version: ["3.10", "3.11", "3.12"]
mdanalysis-version: ["latest", "develop"]
fail-fast: false
matrix:
os: [macOS-latest, ubuntu-latest]
python-version: ["3.10", "3.11", "3.12"]
# We'll test three variants of MDAnalysis:
# - latest (stable from conda-forge)
# - develop (official development branch from conda-forge)
# - imdv3-branch (your custom dev branch from Git)
mdanalysis-version: ["latest", "develop", "imdv3-branch"]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -83,14 +87,23 @@ jobs:


- name: Install MDAnalysis version
if: ${{ matrix.mdanalysis-version == 'latest' || matrix.mdanalysis-version == 'develop' }}
uses: MDAnalysis/install-mdanalysis@main
with:
version: ${{ matrix.mdanalysis-version }}
install-tests: true
installer: conda
shell: bash -l {0}

- name: Install package

# 2) For "imdv3-branch", install from your Git branch
- name: Install MDAnalysis from imdv3 branch
if: ${{ matrix.mdanalysis-version == 'imdv3-branch' }}
run: |
python -m pip install --upgrade pip
pip install "MDAnalysis @ git+https://github.com/amruthesht/mdanalysis.git@imdv3-dev"
pip install "MDAnalysisTests @ git+https://github.com/amruthesht/mdanalysis.git@imdv3-dev"

- name: Install imdclient
run: |
python --version
python -m pip install . --no-deps
Expand Down Expand Up @@ -159,15 +172,14 @@ jobs:
show-channel-urls: true
miniconda-version: latest

- name: Install MDAnalysis version
uses: MDAnalysis/install-mdanalysis@main
with:
version: latest
install-tests: true
installer: conda
shell: bash -l {0}

- name: Install package
# Install your custom MDAnalysis branch for simulation tests as well
- name: Install MDAnalysis from dev branch
run: |
python -m pip install --upgrade pip
pip install "MDAnalysis @ git+https://github.com/amruthesht/mdanalysis.git@imdv3-dev"
pip install "MDAnalysisTests @ git+https://github.com/amruthesht/mdanalysis.git@imdv3-dev"

- name: Install package
run: |
python --version
python -m pip install . --no-deps
Expand Down
9 changes: 6 additions & 3 deletions devtools/conda-envs/test_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@ dependencies:
- pip

# MDAnalysis
- MDAnalysis>=2.7.0
# - MDAnalysis>=2.7.0
-

# Testing
- pytest
- pytest-cov
- pytest-xdist
- codecov
- MDAnalysisTests>=2.7.0
# - MDAnalysisTests>=2.7.0
- docker-py

# Pip-only installs
#- pip:
- pip:
# - codecov
- "MDAnalysis @ git+https://github.com/amruthesht/mdanalysis.git@imdv3-dev"
- "MDAnalysisTests @ git+https://github.com/amruthesht/mdanalysis.git@imdv3-dev"

2 changes: 1 addition & 1 deletion docs/source/api.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
API Documentation
=================

.. automodule:: imdclient.IMD
.. automodule:: MDAanalysis.coordinates.IMD
.. automodule:: imdclient.IMDClient
2 changes: 1 addition & 1 deletion docs/source/usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ Using IMDClient with MDAnalysis
Once the simulation is ready for a client connection, setup your MDAnalysis :class:`Universe`
like this: ::

from IMDClient.IMD import IMDReader
import MDAnalysis as mda
from MDAnalysis.coordinates.IMD import IMDReader
# Pass host and port of the listening simulation
# engine as the trajectory argument

Expand Down
2 changes: 1 addition & 1 deletion examples/gromacs/repo_files/client.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from imdclient.IMD import IMDReader
import MDAnalysis as mda
from MDAnalysis.coordinates.IMD import IMDReader
import logging
from imdclient.tests.datafiles import GROMACS_TOP

Expand Down
2 changes: 1 addition & 1 deletion examples/gromacs/slurm/client.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# NOTE: chamge
from imdclient.IMD import IMDReader
import MDAnalysis as mda
from MDAnalysis.coordinates.IMD import IMDReader
import logging
from imdclient.tests.datafiles import GROMACS_TOP

Expand Down
2 changes: 1 addition & 1 deletion examples/lammps/repo_files/client.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from imdclient.IMD import IMDReader
import MDAnalysis as mda
from MDAnalysis.coordinates.IMD import IMDReader
import logging
from imdclient.tests.datafiles import LAMMPS_TOPOL

Expand Down
2 changes: 1 addition & 1 deletion examples/namd/repo_files/client.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from imdclient.IMD import IMDReader
import MDAnalysis as mda
from MDAnalysis.coordinates.IMD import IMDReader
import logging
from imdclient.tests.datafiles import NAMD_TOPOL

Expand Down
132 changes: 0 additions & 132 deletions imdclient/IMD.py

This file was deleted.

5 changes: 0 additions & 5 deletions imdclient/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,4 @@
from .IMDClient import IMDClient
from importlib.metadata import version

from .streamanalysis import AnalysisBase, StackableAnalysis
from MDAnalysis.analysis import base

base.AnalysisBase = AnalysisBase

__version__ = version("imdclient")
Loading