Load rules_android and providers #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Dec 17, 2024
MODULE.bazel
Outdated
| compatibility_level = 1, | ||
| ) | ||
|
|
||
| bazel_dep(name = "rules_android", version = "0.5.0") |
Owner
There was a problem hiding this comment.
There's a newer version out already, might be worth while just using that directly. 6.0.0 should also decouple us from needing the .bazelrc flags for enabling access to the native providers.
Bencodes
reviewed
Dec 17, 2024
| "AndroidLibraryResourceClassJarProvider", | ||
| "AndroidLibraryAarInfo" | ||
| ) | ||
|
|
Owner
There was a problem hiding this comment.
Can you also add JavaInfo loads as well? They can be loaded from rules_java now.
Owner
|
@kateliu20 can you take a look at the failing CI checks? |
Contributor
Author
|
It seems like the CI checks are all failing because it cannot find rules_android version 6.0.0: edit: I will upgrade to bazel 8 |
kateliu20
force-pushed
the
kl/load-rules-android
branch
from
eb29b36 to
8f26181
Compare
Bencodes
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
bazel build :lintwith bazel version 8 and was able to run successfully after addingrules_androidbazel dep.