Skip to content

Load rules_android and providers #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bencodes merged 10 commits into from
Jan 17, 2025
Merged

Load rules_android and providers #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d6f8cae
Load rules_android and providers
kateliu20 Dec 17, 2024
d23ab76
Rules_android version 6.0.0
kateliu20 Dec 17, 2024
e75150a
load rules_java
kateliu20 Dec 17, 2024
903aae0
Change version rules_android to 0.6.0
kateliu20 Dec 18, 2024
60110ec
Run buildifier on rules/impl.bzl
kateliu20 Jan 15, 2025
3379f18
Upgrade rules_jvm_external to version 6.6
kateliu20 Jan 15, 2025
8f26181
Add providers dep
kateliu20 Jan 15, 2025
3ac0529
Merge branch 'main' into kl/load-rules-android
kateliu20 Jan 16, 2025
a039f19
Add false for check visibility
kateliu20 Jan 16, 2025
3c006bb
Fix failing ci checks
kateliu20 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module(
compatibility_level = 1,
)

bazel_dep(name = "rules_android", version = "0.5.0")
Copy link
Owner

@Bencodes Bencodes Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a newer version out already, might be worth while just using that directly. 6.0.0 should also decouple us from needing the .bazelrc flags for enabling access to the native providers.

Copy link
Contributor Author

@kateliu20 kateliu20 Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I upgraded here: d23ab76

bazel_dep(name = "rules_java", version = "7.0.6")
bazel_dep(name = "rules_jvm_external", version = "5.3")
bazel_dep(name = "rules_kotlin", version = "1.9.5")
Expand Down
5 changes: 5 additions & 0 deletions rules/impl.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ load(
_ANDROID_LINT_TOOLCHAIN_TYPE = "ANDROID_LINT_TOOLCHAIN_TYPE",
_utils = "utils",
)
load(
"@rules_android//providers:providers.bzl",
"AndroidLibraryResourceClassJarProvider",
"AndroidLibraryAarInfo"
)

Copy link
Owner

@Bencodes Bencodes Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add JavaInfo loads as well? They can be loaded from rules_java now.

Copy link
Contributor Author

@kateliu20 kateliu20 Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is like this okay? e75150a

Copy link
Owner

@Bencodes Bencodes Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks correct!

def _run_android_lint(
ctx,
Expand Down
Loading