added clustering and dimensionality reduction to NAP6 menus#392
added clustering and dimensionality reduction to NAP6 menus#392jo-mueller merged 5 commits intov0.9.0from
Conversation
Co-Authored-By: Marcelo Zoccoler <26173597+zoccoler@users.noreply.github.com> Co-Authored-By: Stefan Hahmann <stefanhahmann@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
I think they make sense! I'm not clear on the plugin functionality though. The only one I vaguely question is:
This is not reducing the layer data, but rather, features on the layer, right? So I might consider it more appropriate in Measure (from NAP-6: "Items in this submenu provide utilities for summarising information about your layer’s data. An example would be a widget that plots the change in the intensity of a clicked pixel over time") rather than Project ("Commands that generate various projections based on one or more layers"), which I interpret more as MIP or similar. Having said that all classification systems are lossy and imperfect, so this is a judgement call, and both choices can be defended. 🤷 |
|
Hi @jni , thanks for the feedback! I could agree with moving dimensionality reduction (which operates entirely on features and as such, measurements) to the |
Difficult decision. Reading through the descriptions for the menus and assuming the possibility, I could split my vote, I would do the following:
I am actually missing a category called "Analyse". |
As the NAP itself instructs, this could be proposed by raising an issue on the napari repo! I feel like Analyse itself is too broad — measurement is a form of analysis, for example, and maybe segmentation could be argued to also be a form of analysis — but we could consider it (maybe it subsumes measure). At any rate, it would be good to have this specific use case on our radar, so if we come across something similar we can be like ah-ha — these two things need to be grouped together, what should we call the group. |
|
Incidentally, we've been discussing this internally and we're thinking about adding Layer > Features for functionality related to features, which this could fit into rather well. Thoughts? |
|
@jni Is there an issue to join the discussion? Just above, I think it's possible to live with or without. Even currently, the existing options do not account for whether a plugin should operate on Images/Labels/Surfaces/Features. If there were a new submenu That being said, I'd slightly lean towards not opening the second entry Maybe it'd be possible to display a little icon next to the entry in the |
Sorry, not at the moment — I started it in the core dev chat with an offhand link to this discussion. 😬 I just went over it and there's nothing sensitive there, so once I get folks' permissions I'll move it to the general channel on the Zulip. But anyway, my main point is, NAP-6 is a new thing, we're still figuring it out, and we super appreciate community input and want to make sure you all have a good experience with it! 😊 So please don't hesitate to reach out. For now I will make an issue about Layer > Features and link to this discussion. 🙏 |
This is done now: https://napari.zulipchat.com/#narrow/channel/212875-general/topic/NAP-6.20pigeonholes/near/516142145 although mostly the relevant discussion is happening in napari/napari#7900 now. |
Ok, this will put the widgets (plotter, dim. reduction & clustering) into the contributable menus section. The Plotter itself was there before, but this brings the dim. reductoon and the clustering, too. In 0.9.0, they will then be found here:
Layers > Visualize > Plot & select features (napari clusters plotter)Layers > Project > Dimensionality reduction on features (napari clusters plotter)Layers > Classify > Clustering on features (napari clusters plotter)@jni since you were asking about this on bsky the other day I'd guess I'd ping you, too as an additional pair of eyes ;) Do you think that'd be the appropriate place to put these?
Long copilot description
This pull request updates the
napari.yamlconfiguration for thenapari_clusters_plotterplugin to reorganize menus, enhance clarity in widget display names, and remove unused submenus. Below are the key changes:Menu Reorganization:
napari/layers/projectandnapari/layers/classifyforDimensionality_ReductionandClusteringcommands, respectively.features_submenuand its associated entries to simplify the menu structure.Widget Display Name Updates: