Get test suite building on Linux#165
Merged
justing-bq merged 1 commit intoapache-odbcfrom Mar 31, 2026
Merged
Conversation
justing-bq
force-pushed
the
test_build_linux
branch
2 times, most recently
from
fc15dae to
4350de9
Compare
alinaliBQ
reviewed
Mar 26, 2026
alinaliBQ
reviewed
Mar 26, 2026
alinaliBQ
reviewed
Mar 26, 2026
justing-bq
force-pushed
the
test_build_linux
branch
from
45997d2 to
319275e
Compare
alinaliBQ
reviewed
Mar 27, 2026
Comment on lines
+632
to
+633
| expected_date_time_sub, // expected_date_time_sub | ||
| 0, // expected_octet_char_length |
There was a problem hiding this comment.
For consistency and if this won't break the build, could we pass 0 directly for expected_date_time_sub here and remove expected_date_time_sub = 0?
I see value 0 is accepted for expected_octet_char_length, although expected_octet_char_length is type SQLINTEGER and expected_date_time_sub is SQLSMALLINT; their types are different.
| SQLWCHAR input_str[] = L"SELECT * FROM mytable WHERE id == 1"; | ||
| SQLINTEGER input_char_len = static_cast<SQLINTEGER>(wcslen(input_str)); | ||
| ASSIGN_SQLWCHAR_ARR(input_str, L"SELECT * FROM mytable WHERE id == 1"); | ||
| SQLINTEGER input_char_len = std::wcslen((const wchar_t*)input_str); |
There was a problem hiding this comment.
Let's use c++ style casting (I think it's const_cast<>?)
Comment on lines
+202
to
+211
|
|
||
| SQLSMALLINT expected_unsigned_attr = 0; | ||
| SQLSMALLINT expected_auto_unique_value = 0; | ||
| SQLSMALLINT expected_min_scale = 0; | ||
| SQLSMALLINT expected_max_scale = 0; | ||
| SQLSMALLINT expected_sql_datetime_sub = 0; | ||
| SQLSMALLINT expected_num_prec_radix = 0; | ||
| SQLSMALLINT expected_interval_prec = 0; | ||
| CheckSQLGetTypeInfo(stmt, | ||
| std::wstring(L"bit"), // expected_type_name | ||
| SQL_BIT, // expected_data_type | ||
| 1, // expected_column_size | ||
| std::nullopt, // expected_literal_prefix | ||
| std::nullopt, // expected_literal_suffix | ||
| std::nullopt, // expected_create_params | ||
| SQL_NULLABLE, // expected_nullable | ||
| SQL_FALSE, // expected_case_sensitive | ||
| SQL_SEARCHABLE, // expected_searchable | ||
| NULL, // expected_unsigned_attr | ||
| SQL_FALSE, // expected_fixed_prec_scale | ||
| NULL, // expected_auto_unique_value | ||
| std::wstring(L"bit"), // expected_local_type_name | ||
| NULL, // expected_min_scale | ||
| NULL, // expected_max_scale | ||
| SQL_BIT, // expected_sql_data_type | ||
| NULL, // expected_sql_datetime_sub | ||
| NULL, // expected_num_prec_radix | ||
| NULL); // expected_interval_prec | ||
| std::wstring(L"bit"), // expected_type_name |
There was a problem hiding this comment.
Similar comment as columns_test.cc, Let's pass 0 directly to CheckSQLGetTypeInfo. I think passing 0 instead of NULL here will work because NULL is not defined as 0 on Linux
| GetInfoSQLWCHAR(conn, SQL_COLUMN_ALIAS, value); | ||
|
|
||
| EXPECT_STREQ(static_cast<const SQLWCHAR*>(L"Y"), value); | ||
| std::wstring result = ConvertToWString(value, std::wcslen((const wchar_t*)value)); |
There was a problem hiding this comment.
Same comment here for using C++ style casting
justing-bq
force-pushed
the
test_build_linux
branch
6 times, most recently
from
87e4526 to
1515f56
Compare
justing-bq
force-pushed
the
test_build_linux
branch
from
1515f56 to
2512d90
Compare
justing-bq
force-pushed
the
test_build_linux
branch
from
2512d90 to
ef8318d
Compare
alinaliBQ
reviewed
Mar 31, 2026
alinaliBQ
approved these changes
Mar 31, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
LGTM. Fixing the Linux tests can be in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The test suite needs to be updated so it will build on Linux in addition to Windows & Mac.
What changes are included in this PR?
Miscellaneous changes to get the tests building on Linux.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.