Open
Conversation
Input component already has default styling, and CSS variables such as var(--color-primary-rgb) seem halucinated. The selector didn't target the search input element anymore, but when fixing the selectors the search field is invisible in dark mode. Removing the unnecessary styling. Related - a45bb14
Regression introduced in: - a45bb14
As parent element has a minimum height the margin after the choose name input field has no effect.
Fee amount and fee unit in custom fee input did not perfectly align.
thisconnect
commented
Feb 12, 2026
|
|
||
| @media (max-width: 768px) { | ||
| .searchInput { | ||
| .searchInput > div { |
Collaborator
Author
There was a problem hiding this comment.
I'd like to open a new PR building on top this one to remove the selector "hack".
But it would be great to merge this first.
thisconnect
commented
Feb 12, 2026
| .searchInput:focus { | ||
| outline: none; | ||
| border-color: var(--color-primary); | ||
| box-shadow: 0 0 0 2px rgba(var(--color-primary-rgb), 0.1); |
Collaborator
Author
There was a problem hiding this comment.
AI hallucination? we never had --color-primary-rgb CSS varaiblae afaik.
thisconnect
commented
Feb 12, 2026
| margin-bottom: var(--space-half); | ||
| min-width: 320px; | ||
| width: 100%; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
The regression is that .searchInput was before added to the input element and now it's on a container element. So all these styles are on the container.
This would fix the selectors, but then the UI looks broken, not sure if these styles were ever used 🤔
diff --git a/frontends/web/src/routes/account/account.module.css b/frontends/web/src/routes/account/account.module.css
index 10c087201..ff3b578e9 100644
--- a/frontends/web/src/routes/account/account.module.css
+++ b/frontends/web/src/routes/account/account.module.css
@@ -187,7 +187,7 @@
transform: translateY(-10px);
}
-.searchInput {
+.searchInput > div {
background-color: var(--color-background);
border: 1px solid var(--color-border);
border-radius: 4px;
@@ -200,18 +200,18 @@
width: 100%;
}
-.searchInput:focus {
+.searchInput > div:focus-within {
outline: none;
border-color: var(--color-primary);
box-shadow: 0 0 0 2px rgba(var(--color-primary-rgb), 0.1);
}
-.searchInput::placeholder {
+.searchInput input::placeholder {
color: var(--color-secondary);
}
@media (max-width: 768px) {
- .searchInput {
+ .searchInput > div {
padding-right: 0;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #3863 there are 2 CSS selectors that target the child components. For this reason I wanted to update Input and related components to accept class on the field element. So we don't have to do:
.inputClassName > divHowever I found some small bugs and regressions, which this PR should fix.