Skip to content

Frontend fix input styling #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisconnect wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Frontend fix input styling #3865

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58b614d
frontend: remove unnecessary account search styling
thisconnect Feb 12, 2026
2bba16d
frontend: fix error styling regression
thisconnect Feb 12, 2026
df0c77b
frontend: remove unnecessary add-account choose name input style
thisconnect Feb 12, 2026
bba77c8
frontend: tiny custom feetarget fix
thisconnect Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions frontends/web/src/routes/account/account.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,31 +187,8 @@
transform: translateY(-10px);
}

.searchInput {
background-color: var(--color-background);
border: 1px solid var(--color-border);
border-radius: 4px;
color: var(--color-text);
font-size: var(--size-default);
transition: border-color 0.2s ease;
margin: 0;
margin-bottom: var(--space-half);
min-width: 320px;
width: 100%;
}
Copy link
Collaborator Author

@thisconnect thisconnect Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regression is that .searchInput was before added to the input element and now it's on a container element. So all these styles are on the container.

This would fix the selectors, but then the UI looks broken, not sure if these styles were ever used 🤔

diff --git a/frontends/web/src/routes/account/account.module.css b/frontends/web/src/routes/account/account.module.css
index 10c087201..ff3b578e9 100644
--- a/frontends/web/src/routes/account/account.module.css
+++ b/frontends/web/src/routes/account/account.module.css
@@ -187,7 +187,7 @@
     transform: translateY(-10px);
 }
 
-.searchInput {
+.searchInput > div {
     background-color: var(--color-background);
     border: 1px solid var(--color-border);
     border-radius: 4px;
@@ -200,18 +200,18 @@
     width: 100%;
 }
 
-.searchInput:focus {
+.searchInput > div:focus-within {
     outline: none;
     border-color: var(--color-primary);
     box-shadow: 0 0 0 2px rgba(var(--color-primary-rgb), 0.1);
 }
 
-.searchInput::placeholder {
+.searchInput input::placeholder {
     color: var(--color-secondary);
 }
 
 @media (max-width: 768px) {
-    .searchInput {
+    .searchInput > div {
         padding-right: 0;
     }


.searchInput:focus {
outline: none;
border-color: var(--color-primary);
box-shadow: 0 0 0 2px rgba(var(--color-primary-rgb), 0.1);
Copy link
Collaborator Author

@thisconnect thisconnect Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI hallucination? we never had --color-primary-rgb CSS varaiblae afaik.

}

.searchInput::placeholder {
color: var(--color-secondary);
}

@media (max-width: 768px) {
.searchInput {
.searchInput > div {
Copy link
Collaborator Author

@thisconnect thisconnect Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to open a new PR building on top this one to remove the selector "hack".

But it would be great to merge this first.

padding-right: 0;
}

Expand Down