feat(abstract-utxo): deprecate 'legacy' txFormat on btc testnets #7499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new type to tx format to support psbt-lite, a more lightweight version of the PSBT format for transaction signing. Issue: BTC-2732 Co-authored-by: llm-git <[email protected]>
Extract logic to determine transaction format into a dedicated method to improve readability and maintainability. Now using explicit return values instead of relying on a boolean evaluation for PSBT format. Issue: BTC-2732 Co-authored-by: llm-git <[email protected]>
Validate that the txFormat parameter is one of the allowed values for testnet networks to prevent invalid inputs. Added new utility function and error class to handle validation. Issue: BTC-2732 Co-authored-by: llm-git <[email protected]>
Refactor `getTxFormat` method to prioritize explicitly requested txFormat when provided. Default to PSBT for certain wallet types only when no format is specified. Issue: BTC-2732 Co-authored-by: llm-git <[email protected]>
Forces PSBT format for Bitcoin Testnet hot wallets and explicitly handles Zcash separately. This change maintains legacy format for Zcash while ensuring all other UTXO-based coins on testnet use PSBT format. Issue: BTC-2732 Co-authored-by: llm-git <[email protected]>
OttoAllmendinger
changed the title
Force PSBT for testnet Bitcoin by rejecting 'legacy' format and defaulting to 'psbt-lite' for Bitcoin testnet networks. Add new error class for deprecated transaction formats. Issue: BTC-2732 Co-authored-by: llm-git <[email protected]>
OttoAllmendinger
force-pushed
the
BTC-2732.force-psbt-in-bitcoin-testnet
branch
from
98e5df1 to
7410da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several improvements to the transaction format handling
in the abstract-utxo module:
transaction signing
better maintainability
separately
defaulting to 'psbt-lite'
Issue: BTC-2732