feat: bump miniscript crate to 12.3.4 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: llm-git <[email protected]> Issue: BTC-2650
Moves the assertion that checks `.atDerivationIndex(0)` doesn't throw inside the conditional block that verifies the descriptor is derivable. The new rust-miniscript version fails at the `.atDerivationIndex(0)` call which frankly makes more sense. Issue: BTC-2650 Co-authored-by: llm-git <[email protected]>
Small difference in miniscript version Issue: BTC-2650 Co-authored-by: llm-git <[email protected]>
louib
approved these changes
Oct 23, 2025
davidkaplanbitgo
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the miniscript crate to version 12.3.4 and makes necessary
test adjustments to accommodate the new version.
Changes:
.atDerivationIndex(0)whichis more logical
updated miniscript version
Issue: BTC-2650