Fix: segfault due to use after free in workers thread #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeDisconnect calls worker.WorkComplete() tells V8 persistent callback to be freed, while the thread is still alive, creating use after free segmentation fault. Fixes Blizzard#1057
|
Would it be possible to fix this by adding the IsEmpty() check to this if statement instead of |
|
Yes, it is better in the worker itself, i will run a test and update |
NodeDisconnect calls worker.WorkComplete() which deletes the callback, while the thread is still alive, creating use after free segmentation fault.
Fix: segfault due to use after free in workers thread
|
Reopened new pull request #1138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NodeDisconnect calls worker.WorkComplete() and Destroy() sets the callback to null, while the thread is stopping or starting in a race, creating "use after free" segmentation fault in the message callback handler on Linux.
Closes: #1057
cc: @GaryWilber