Skip to content

Fix: segfault due to use after free in workers thread #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix: segfault due to use after free in workers thread #1136

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af037da
Fix: segfault due to use after free in workers thread
constantind Aug 8, 2025
0b0ba3b
Merge branch 'Blizzard:master' into patch-1
constantind Aug 22, 2025
bbcc6fc
Fix: segfault due to use after free in workers thread
constantind Aug 22, 2025
d01e1ea
Merge pull request #1 from constantind/constantind-patch-1
constantind Aug 22, 2025
ac0736a
Revert changes in workers.cc
constantind Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/workers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,19 @@ class MessageWorker : public ErrorAwareWorker {
}

for (unsigned int i = 0; i < message_queue.size(); i++) {
HandleMessageCallback(message_queue[i], RdKafka::ERR_NO_ERROR);
if (callback && !callback->IsEmpty()) {
HandleMessageCallback(message_queue[i], RdKafka::ERR_NO_ERROR);
}

// we are done with it. it is about to go out of scope
// for the last time so let's just free it up here. can't rely
// on the destructor
}

for (unsigned int i = 0; i < warning_queue.size(); i++) {
HandleMessageCallback(NULL, warning_queue[i]);
if (callback && !callback->IsEmpty()) {
HandleMessageCallback(NULL, warning_queue[i]);
}
}
}

Expand Down