Skip to content

Add high precision IMU message for the new ADIS IMU #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 17, 2025
Merged

Add high precision IMU message for the new ADIS IMU #195

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8997ceb
Add high precision IMU message
haavardsyslak Apr 22, 2025
39fea7c
Add comment to keep consistency
haavardsyslak Apr 25, 2025
a0c25f3
no magnetometer
haavardsyslak Apr 25, 2025
82e8fbb
Merge branch 'master' into hs/adis
haavardsyslak Aug 14, 2025
3928ff1
Merge branch 'master' into hs/adis
haavardsyslak Sep 2, 2025
fd94b22
add calibrated adis imu
haavardsyslak Sep 4, 2025
1734682
Merge branch 'master' into hs/adis
haavardsyslak Sep 16, 2025
852ab00
Add comment (no magnetometer)
haavardsyslak Sep 16, 2025
a869e67
revert back name
haavardsyslak Sep 16, 2025
4f8b007
rename ImuHp msg
haavardsyslak Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions protobuf_definitions/telemetry.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ message Imu2Tel {
Imu imu = 1; // Raw IMU data.
}

// Raw IMU data from high precision IMU
message ImuHpTel {
Imu imu = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add // Raw IMU data. to make it consistent with the others, maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
Also add a comment that there is no Magnetometer in contrast to the other IMUs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically do not have product names in the message definitions, as we might try another IMU sometime in the future. So maybe it's better to keep ImuHpTel or ImuPerformanceTel and CalibratedPerformanceImuTel? Then we can add Adis in the comments, because that is easier to change later. @haavardsyslak

}

// Medusa gamma ray sensor spectrometer data.
message MedusaSpectrometerDataTel {
MedusaSpectrometerData data = 1; // Medusa gamma ray sensor spectrometer data.
Expand Down