Skip to content

Conversation

haavardsyslak
Copy link
Contributor

No description provided.

@haavardsyslak haavardsyslak requested a review from aviggen April 22, 2025 11:26
@@ -252,6 +252,11 @@ message Imu2Tel {
Imu imu = 1; // Raw IMU data.
}

// Raw IMU data from high precision IMU
message ImuHpTel {
Imu imu = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add // Raw IMU data. to make it consistent with the others, maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
Also add a comment that there is no Magnetometer in contrast to the other IMUs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically do not have product names in the message definitions, as we might try another IMU sometime in the future. So maybe it's better to keep ImuHpTel or ImuPerformanceTel and CalibratedPerformanceImuTel? Then we can add Adis in the comments, because that is easier to change later. @haavardsyslak

@follesoe follesoe added this to the Blunux v4.6 milestone Sep 5, 2025
@haavardsyslak haavardsyslak marked this pull request as ready for review September 16, 2025 08:31
@aviggen
Copy link
Contributor

aviggen commented Sep 16, 2025

Here is an option if we want to log more data in the future:

import "google/protobuf/any.proto";

// Calibrated High Precision IMU data
message CalibratedImuHpTel {
  Imu imu = 1; // Calibrated High Precision IMU (no magnetometer)

  // Optional vendor-specific extension
  google.protobuf.Any vendor_extension = 100; // e.g. ADIS, Bosch, Xsens...
}

message AdisImuExtension {
  Vector3 delta_angle    = 1; // rad
  Vector3 delta_velocity = 2; // m/s
}

message XsenseImuExtension {
  double temperature = 1;  // °C
  double bias_level  = 2;  // rad/s or m/s²
}

@aviggen aviggen merged commit aa41f56 into master Sep 17, 2025
3 checks passed
@aviggen aviggen deleted the hs/adis branch September 17, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants