-
Notifications
You must be signed in to change notification settings - Fork 3
Add high precision IMU message for the new ADIS IMU #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
protobuf_definitions/telemetry.proto
Outdated
@@ -252,6 +252,11 @@ message Imu2Tel { | |||
Imu imu = 1; // Raw IMU data. | |||
} | |||
|
|||
// Raw IMU data from high precision IMU | |||
message ImuHpTel { | |||
Imu imu = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add // Raw IMU data
. to make it consistent with the others, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Also add a comment that there is no Magnetometer in contrast to the other IMUs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically do not have product names in the message definitions, as we might try another IMU sometime in the future. So maybe it's better to keep ImuHpTel
or ImuPerformanceTel
and CalibratedPerformanceImuTel
? Then we can add Adis in the comments, because that is easier to change later. @haavardsyslak
Here is an option if we want to log more data in the future:
|
No description provided.