Skip to content

Conversation

@gabitoesmiapodo
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings October 21, 2025 17:43
@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Canceled Canceled Oct 21, 2025 6:00pm

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates localization files with new Crowdin translations, specifically handling the replacement of a message string related to token approval in active orders across multiple language files.

Key Changes:

  • Updated revision dates in all locale files to 2025-10-21 17:43
  • Replaced an existing token approval message with a revised version that clarifies the impact of partial approvals
  • Reorganized translation entries by marking the old message as obsolete and introducing the new message

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Marked old token approval message as obsolete and added new version with empty translation
apps/cowswap-frontend/src/locales/es-ES.po Marked old token approval message as obsolete and added new version with empty translation
apps/cowswap-frontend/src/locales/en-US.po Removed the newer message variant and restored the original message as active

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

msgid "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
msgstr "Там {areIs} <0>{ordersWithPermitLength}</0> существующий {orderWord} с <1/> одобрением токена. Если вы подписываете новый, может быть только один ордер. Продолжить с текущей суммой разрешения или выбрать полное утверждение, чтобы все заказы могут быть исполнены."
#~ msgid "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
#~ msgstr "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation entry has been replaced with untranslated English text instead of preserving the original Russian translation. This should retain the Russian text: 'Там {areIs} <0>{ordersWithPermitLength}</0> существующий {orderWord} с <1/> одобрением токена. Если вы подписываете новый, может быть только один ордер. Продолжить с текущей суммой разрешения или выбрать полное утверждение, чтобы все заказы могут быть исполнены.'

Suggested change
#~ msgstr "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
#~ msgstr "Там {areIs} <0>{ordersWithPermitLength}</0> существующий {orderWord} с <1/> одобрением токена. Если вы подписываете новый, может быть только один ордер. Продолжить с текущей суммой разрешения или выбрать полное утверждение, чтобы все заказы могут быть исполнены."

Copilot uses AI. Check for mistakes.
msgid "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
msgstr "Hay <0>{ordersWithPermitLength}</0> {orderWord} usando una aprobación de token <1/>. Si firma uno nuevo, sólo puede llenar una orden. Continúe con la cantidad actual aprobada o elija la aprobación completa para que todas las órdenes puedan ser llenadas."
#~ msgid "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
#~ msgstr "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation entry has been replaced with untranslated English text instead of preserving the original Spanish translation. This should retain the Spanish text: 'Hay <0>{ordersWithPermitLength}</0> {orderWord} usando una aprobación de token <1/>. Si firma uno nuevo, sólo puede llenar una orden. Continúe con la cantidad actual aprobada o elija la aprobación completa para que todas las órdenes puedan ser llenadas.'

Suggested change
#~ msgstr "There {areIs} <0>{ordersWithPermitLength}</0> existing {orderWord} using a <1/> token approval. If you sign a new one, only one order can fill. Continue with current permit amount or choose full approval so all orders can be filled."
#~ msgstr "Hay <0>{ordersWithPermitLength}</0> {orderWord} usando una aprobación de token <1/>. Si firma uno nuevo, sólo puede llenar una orden. Continúe con la cantidad actual aprobada o elija la aprobación completa para que todas las órdenes puedan ser llenadas."

Copilot uses AI. Check for mistakes.
@gabitoesmiapodo gabitoesmiapodo merged commit d378232 into feat/internationalization-setup-for-swap-cow-fi Oct 21, 2025
4 of 7 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch October 21, 2025 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants