[MA-27]: MM-61599: Remove tabIndex from non-interactive elements by SaurabhSharma-884 · Pull Request #23 · Brightscout/mattermost

SaurabhSharma-884 · 2024-12-16T12:36:25Z

Summary

The PR ensures focus order of interactive elements on the page is logical and focus is not moved to non-interactive elements of the page.

Steps to reproduce

Navigate to the page using tab key until reaches the entire section of the At 8:08 PM Monday, September 23, Someone wrote, user joined the team text.
Notice that non-interactive elements receive focus.

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-61599

Screenshots

Screencast.from.2024-12-16.18-04-35.webm

Release Note

ayush-chauhan233 · 2024-12-19T13:52:01Z

webapp/platform/components/src/generic_modal/__snapshots__/generic_modal.test.tsx.snap

    />
    <div
-      role="dialog"
+      role="none"


Why did this change to none?

mattermost#29731)

… in AdvancedTextEditor (mattermost#29754)

* Translated using Weblate (Italian) Currently translated at 82.4% (2148 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/it/ * Translated using Weblate (Italian) Currently translated at 56.2% (3385 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/it/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 93.9% (2448 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt_BR/ * Translated using Weblate (Kazakh) Currently translated at 16.1% (973 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 60.3% (3635 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Kazakh) Currently translated at 16.2% (978 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 60.4% (3639 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Russian) Currently translated at 97.4% (2538 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/ru/ * Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (2605 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/zh_Hans/ * Translated using Weblate (Russian) Currently translated at 94.9% (5720 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ru/ * Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (6022 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/zh_Hans/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 95.8% (2497 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt_BR/ * Translated using Weblate (German) Currently translated at 100.0% (2605 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/de/ * Translated using Weblate (German) Currently translated at 100.0% (6022 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/de/ * Translated using Weblate (Czech) Currently translated at 100.0% (2605 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/ * Translated using Weblate (Czech) Currently translated at 100.0% (6022 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/cs/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 97.1% (2530 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt_BR/ * Translated using Weblate (Ukrainian) Currently translated at 99.9% (2603 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/uk/ * Translated using Weblate (Kazakh) Currently translated at 16.5% (999 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/ * Translated using Weblate (Kazakh) Currently translated at 17.1% (1032 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/ * Translated using Weblate (Kazakh) Currently translated at 17.2% (1038 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/ * Translated using Weblate (Dutch) Currently translated at 99.8% (2600 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/nl/ * Translated using Weblate (Dutch) Currently translated at 99.9% (6021 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nl/ * Translated using Weblate (Dutch) Currently translated at 99.8% (2602 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/nl/ * Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (6022 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/zh_Hans/ * Translated using Weblate (Polish) Currently translated at 100.0% (2605 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pl/ * Translated using Weblate (Polish) Currently translated at 100.0% (6022 of 6022 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Czech) Currently translated at 100.0% (2605 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/ * Translated using Weblate (Czech) Currently translated at 100.0% (2605 of 2605 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/ --------- Co-authored-by: Andrea <andrea.biasi@gmail.com> Co-authored-by: Henrique Latorre <hpflatorre@gmail.com> Co-authored-by: Akbar Abdrakhmanov <kz.akbar@gmail.com> Co-authored-by: Frank Paul Silye <frankps@gmail.com> Co-authored-by: Konstantin <eleferen@gmail.com> Co-authored-by: ThrRip <coding@thrrip.space> Co-authored-by: jprusch <rs@schaeferbarthold.de> Co-authored-by: Martin Mičuda <micuda@rematiptop.cz> Co-authored-by: Serhii Khomiuk <sergiy.khomiuk@gmail.com> Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> Co-authored-by: master7 <marcin.karkosz@rajska.info> Co-authored-by: Massimo Marassi <backoffice@rematiptop.cz> Co-authored-by: Mattermost Build <build@mattermost.com>

…hTooltip and other related minor improvements (mattermost#29730)

…#29728) We cannot simply use Elasticsearch any more because we support Opensearch as well. Therefore changing Elasticsearch to just say Search. Note: There are still some cases where Elasticsearch is used. That is intentional and necessary. ```release-note NONE ```

…termost#29526) * add Standard message priority and system setting test * Refactor message priority config and test. * Refactor to use new priority dialog locators and checks, ensuring default standard option is correctly verified. * Fix whitespace and formatting in message priority components. --------- Co-authored-by: Fume <contact@fumedev.com> Co-authored-by: Mattermost Build <build@mattermost.com>

* update text, add tests * remove commented lines * lint fix * i18n-extract * add additional changes * update test, change other text * update test names --------- Co-authored-by: Mattermost Build <build@mattermost.com>

Automatic Merge

…o insert to database (mattermost#29589) * Add missing URL length validation in LinkMetadata * Added MaxURLLength constant * Add test to validate new URL length limit * Add comment about table constraint * Use a seperate error string for URL length errors * Added error string fpr URL length * Updated error message * Update en.json * Fixed gofmt error in link_metadata.go * use right txn id ```release-note NONE ``` --------- Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in> Co-authored-by: Mattermost Build <build@mattermost.com>

The default role permissions weren't being saved to a separate variable which would have not restored them properly. This was a problem in various other tests, potentially causing side-effects in other flaky tests as well. We fix that, as well as clean up the for loop a bit and mention how many messages were recieved in the failure message so that it becomes clear whether no messages were recieved, or atleast some were received. https://mattermost.atlassian.net/browse/MM-62079 ```release-note NONE ```

…most#29774) As in the comments I added, this is to fix an error introduced by changes made by either Firefox or 1Password due to accessing a performance metric's details field when we're not allowed to.

* [MA-12]: Add label to form field in channel header * [MA-12]: Update aria attributes and tests * [MA-12]: Update snapshots, fix e2e test * [MA-12]: Fix E2E tests * [MA-12]: Fix type in test

)

* MM-62226 - set focus back to search button * fix linter

…t#29605) * Reduce number of IDE warnings in permissions_migrations.go * Fix comment language

github-actions · 2025-01-10T08:18:06Z

⚠️ One or more flaky tests detected ⚠️

Failing job: github.com/mattermost/mattermost:MySQL
Double check your code to ensure you haven't introduced a flaky test.
If this seems to be unrelated to your changes, submit a separate pull request to skip the flaky tests (e.g. 23360) and file JIRA ticket (e.g. MM-52743) for later investigation.

Test	Retries
MySQL (Results)
com/mattermost/mattermost/server/v8/channels/api4.TestPublishUserTyping/should_send_typing_event_via_websocket_when_triggering_a_typing_event_for_a_user_with_a_common_channel	1
com/mattermost/mattermost/server/v8/channels/api4.TestPublishUserTyping	1

SaurabhSharma-884 requested a review from thisisankur0 December 16, 2024 12:36

SaurabhSharma-884 self-assigned this Dec 16, 2024

SaurabhSharma-884 force-pushed the ma_27/issue_mm_61599 branch from 0e20ba4 to 281be0e Compare December 16, 2024 13:01

SaurabhSharma-884 requested review from ayush-chauhan233 and removed request for thisisankur0 December 17, 2024 09:05

ayush-chauhan233 reviewed Dec 19, 2024

View reviewed changes

ayush-chauhan233 approved these changes Dec 19, 2024

View reviewed changes

SaurabhSharma-884 added the On External label Dec 20, 2024

SaurabhSharma-884 added the Approved Dev approved, ready to be reviewed by MM team label Dec 27, 2024

M-ZubairAhmed and others added 6 commits January 6, 2025 15:52

[MM-62302] Edit message update "post too long" error message placement (

56baba3

mattermost#29731)

[MM-62403] Seperate MessageWithMentionsFooter into separate component…

1db330c

… in AdvancedTextEditor (mattermost#29754)

[MM-61800] Email is cut off in profile popover (mattermost#29753)

7005a9e

[MA-27]: Remove tabIndex from non-interactive elements

697feda

[MA-27]: Fix E2E tests

2bbd136

SaurabhSharma-884 force-pushed the ma_27/issue_mm_61599 branch from 281be0e to 2bbd136 Compare January 7, 2025 11:37

M-ZubairAhmed and others added 14 commits January 7, 2025 18:40

[MM-62390] Combine the floating and transition styles into one in Wit…

e0e24aa

…hTooltip and other related minor improvements (mattermost#29730)

MM-61926 Channel Conversion Text and add test (mattermost#29498)

b74c219

* update text, add tests * remove commented lines * lint fix * i18n-extract * add additional changes * update test, change other text * update test names --------- Co-authored-by: Mattermost Build <build@mattermost.com>

Update latest minor version to 10.5.0 (mattermost#29779)

22856b4

Automatic Merge

Fix: Playwright e2e tests (mattermost#29768)

e6b4764

MM-62371 Add additional error handling to PerformanceReporter (matter…

e7c583f

…most#29774) As in the comments I added, this is to fix an error introduced by changes made by either Firefox or 1Password due to accessing a performance metric's details field when we're not allowed to.

MM-61411 - fix incorrect linking case sensitive issue (mattermost#29683)

3a13dc2

[MM-61571]: Add label to form field in channel header (mattermost#29553)

a3b2ece

* [MA-12]: Add label to form field in channel header * [MA-12]: Update aria attributes and tests * [MA-12]: Update snapshots, fix e2e test * [MA-12]: Fix E2E tests * [MA-12]: Fix type in test

[MM-62381] Move LinkTooltip from Popper to Floating-UI (mattermost#29727

db3b72e

)

Remove duplicate SAML login error message (mattermost#29767)

e8beefd

MM-62226 - set focus back to search button (mattermost#29669)

882654d

* MM-62226 - set focus back to search button * fix linter

enzowritescode and others added 4 commits January 9, 2025 11:33

Reduce number of IDE warnings in permissions_migrations.go (mattermos…

0c213ea

…t#29605) * Reduce number of IDE warnings in permissions_migrations.go * Fix comment language

MM-62426: Remove form-data from @mattermost/client (mattermost#29792)

95b22f4

Merge branch 'master' into MM-61599

93a5f0a

[MA-27]: Remove unnecessary test

1a46932

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MA-27]: MM-61599: Remove tabIndex from non-interactive elements#23

[MA-27]: MM-61599: Remove tabIndex from non-interactive elements#23
SaurabhSharma-884 wants to merge 24 commits intomasterfrom
ma_27/issue_mm_61599

SaurabhSharma-884 commented Dec 16, 2024

Uh oh!

ayush-chauhan233 Dec 19, 2024

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Conversation

SaurabhSharma-884 commented Dec 16, 2024

Summary

Steps to reproduce

Ticket Link

Screenshots

Release Note

Uh oh!

ayush-chauhan233 Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 10, 2025

⚠️ One or more flaky tests detected ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants