Skip to content

MM-61633: Add aria-label in the onboarding button#41

Open
SaurabhSharma-884 wants to merge 3 commits intomasterfrom
MM-61633
Open

MM-61633: Add aria-label in the onboarding button#41
SaurabhSharma-884 wants to merge 3 commits intomasterfrom
MM-61633

Conversation

@SaurabhSharma-884
Copy link

@SaurabhSharma-884 SaurabhSharma-884 commented Dec 26, 2024

Summary

There are buttons with insufficiently descriptive accessible names. Examples include:

Welcome to Mattermost 5

Steps to reproduce

  • Locate the "Welcome to Mattermost 5" button.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Name".

Ticket Link

https://mattermost.atlassian.net/browse/MM-61633

Screenshots

before after
image image

Release Note

NONE

Copy link

@ayush-chauhan233 ayush-chauhan233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description

@ayush-chauhan233 ayush-chauhan233 self-requested a review January 8, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants