Skip to content

MM-61633: Add aria-label in the onboarding button #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaurabhSharma-884 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MM-61633: Add aria-label in the onboarding button #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed16956
MM-61633: Add aria-label in the onboarding button
SaurabhSharma-884 Dec 26, 2024
b47440f
MM-61633: Update formatting
SaurabhSharma-884 Dec 26, 2024
574e7fb
MM-61633: Add strings for localization
SaurabhSharma-884 Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// See LICENSE.txt for license information.

import React, {useRef, useCallback, useEffect, useState} from 'react';
import {FormattedMessage} from 'react-intl';
import {FormattedMessage, useIntl} from 'react-intl';
import {useDispatch, useSelector} from 'react-redux';
import styled, {css} from 'styled-components';

Expand Down Expand Up @@ -124,6 +124,7 @@ const Button = styled.button<{open: boolean}>(({open}) => {
});

const OnBoardingTaskList = (): JSX.Element | null => {
const {formatMessage} = useIntl();
const hasPreferences = useSelector((state: GlobalState) => Object.keys(getMyPreferencesSelector(state)).length !== 0);

useEffect(() => {
Expand Down Expand Up @@ -253,6 +254,7 @@ const OnBoardingTaskList = (): JSX.Element | null => {
ref={trigger}
open={open}
data-cy='onboarding-task-list-action-button'
aria-label={formatMessage({id: 'onboardingTask.checklist.start_onboarding_process', defaultMessage: 'Start the onboarding process.'})}
>
{open ? <CloseIcon size={20}/> : <PlaylistCheckIcon size={20}/>}
{itemsLeft !== 0 && (<span>{itemsLeft}</span>)}
Expand Down
1 change: 1 addition & 0 deletions webapp/channels/src/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4556,6 +4556,7 @@
"onboardingTask.checklist.main_subtitle": "Let's get up and running.",
"onboardingTask.checklist.no_thanks": "No, thanks",
"onboardingTask.checklist.start_enterprise_now": "Start your free Enterprise trial now!",
"onboardingTask.checklist.start_onboarding_process": "Start the onboarding process.",
"onboardingTask.checklist.task_complete_your_profile": "Complete your profile.",
"onboardingTask.checklist.task_download_mm_apps": "Download the Desktop and Mobile Apps.",
"onboardingTask.checklist.task_invite_team_members": "Invite team members to the workspace.",
Expand Down