Updating package-lock.json #4957
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
d2l-github-action-tokens
bot
force-pushed
the
ghworkflow/package_lock_auto_update
branch
from
ae9bb7c to
6e691a2
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| <div style=${styleMap(slotStyles)}><slot></slot></div> | ||
| `; | ||
|
|
||
| if (!this._titleId) this._titleId = getUniqueId(); |
There was a problem hiding this comment.
I think we should just set this._titleId = getUniqueId() in the constructor. We do this already in a bunch of places, and it would avoid needing to do it in willUpdate.
|
|
||
| willUpdate(changedProperties) { | ||
| super.willUpdate(changedProperties); | ||
| this._width = Math.max(1170, this.width); |
There was a problem hiding this comment.
Wondering if this should be:
if (changedProperties.has('width')) {
this._width = Math.max(1170, this.width);
}| 'd2l-footer-no-content': !this._hasFooterContent | ||
| }; | ||
|
|
||
| if (!this._textId && this.describeContent) this._textId = getUniqueId(); |
There was a problem hiding this comment.
Again, I think we should just always set this._textId in the constructor to avoid this situation. In this case, we'd be setting it sometimes when we don't need it (i.e. if this.describeContent is false), but it's cheap to generate an ID even if it doesn't get used.
components/inputs/input-date.js
Outdated
|
|
||
| willUpdate(changedProperties) { | ||
| super.willUpdate(changedProperties); | ||
| this.style.maxWidth = this.inputTextWidth; |
There was a problem hiding this comment.
| this.style.maxWidth = this.inputTextWidth; | |
| if (changedProperties.has('_hiddenContentWidth')) { | |
| this.style.maxWidth = this.inputTextWidth; | |
| } |
components/inputs/input-time.js
Outdated
| const inputTextWidth = `calc(${this._hiddenContentWidth} + 1.5rem + 3px)`; // text and icon width + left & right padding + border width + 1 | ||
| this.style.maxWidth = inputTextWidth; |
There was a problem hiding this comment.
Nit: I'd probably just merge these lines.
| const inputTextWidth = `calc(${this._hiddenContentWidth} + 1.5rem + 3px)`; // text and icon width + left & right padding + border width + 1 | |
| this.style.maxWidth = inputTextWidth; | |
| this.style.maxWidth = `calc(${this._hiddenContentWidth} + 1.5rem + 3px)`; // text and icon width + left & right padding + border width + 1; |
| 'd2l-link-small': this.type === 'small', | ||
| 'd2l-skeletize': true | ||
| }; | ||
| const widthSkeletonSize = `d2l-skeletize-${this.width}`; |
There was a problem hiding this comment.
Interesting... so the new linting rules hated just referencing this.something in this case?
There was a problem hiding this comment.
My theory is that there is an error in some regex, any reference to this on the left-hand side of an assignment will break the rule. Which makes sense to prevent assigning properties on render(), but not so much when using it as an object key.
d2l-github-action-tokens
bot
force-pushed
the
ghworkflow/package_lock_auto_update
branch
from
9164c99 to
ea3b117
Compare
…com/BrightspaceUI/core into ghworkflow/package_lock_auto_update
dlockhart
left a comment
dlockhart
left a comment
There was a problem hiding this comment.
Looks good! And then if Danny's proposal makes it through, we can revert some of this.
d2l-github-action-tokens
bot
deleted the
ghworkflow/package_lock_auto_update
branch
|
🎉 This PR is included in version 3.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Automatic update of the
package-lock.jsonfile.Dependency Changes