-
Notifications
You must be signed in to change notification settings - Fork 28
Updating package-lock.json #4957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6e691a2
d129643
fa8c6da
9164c99
ef820a3
ea3b117
ab20122
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| "browsers": [ | ||
| { | ||
| "name": "Chromium", | ||
| "version": 128 | ||
| "version": 129 | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -105,6 +105,7 @@ class Dialog extends LocalizeCoreElement(AsyncContainerMixin(DialogMixin(LitElem | |
| this._criticalLabelId = getUniqueId(); | ||
| this._handleResize = this._handleResize.bind(this); | ||
| this._titleId = getUniqueId(); | ||
| this._textId = getUniqueId(); | ||
| } | ||
|
|
||
| get asyncContainerCustom() { | ||
|
|
@@ -158,7 +159,6 @@ class Dialog extends LocalizeCoreElement(AsyncContainerMixin(DialogMixin(LitElem | |
| 'd2l-footer-no-content': !this._hasFooterContent | ||
| }; | ||
|
|
||
| if (!this._textId && this.describeContent) this._textId = getUniqueId(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, I think we should just always set |
||
| const content = html` | ||
| ${loading} | ||
| <div id="${ifDefined(this._textId)}" style=${styleMap(slotStyles)}><slot></slot></div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,8 +36,9 @@ export class SkeletonTestLink extends SkeletonMixin(LitElement) { | |
| 'd2l-link-small': this.type === 'small', | ||
| 'd2l-skeletize': true | ||
| }; | ||
| const widthSkeletonSize = `d2l-skeletize-${this.width}`; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting... so the new linting rules hated just referencing
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My theory is that there is an error in some regex, any reference to |
||
| if (this.width !== undefined) { | ||
| classes[`d2l-skeletize-${this.width}`] = true; | ||
| classes[widthSkeletonSize] = true; | ||
| } | ||
| return html`<a href="https://d2l.com" class="${classMap(classes)}">Link (${this.type})</a>`; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just set
this._titleId = getUniqueId()in the constructor. We do this already in a bunch of places, and it would avoid needing to do it inwillUpdate.