feat: auto-close menus and adjust logo size when navbar collapses#17717
feat: auto-close menus and adjust logo size when navbar collapses#17717poirazis wants to merge 2 commits intoBudibase:masterfrom
Conversation
|
just a note from an implementer's perspective: Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow I don't think limiting the size to 32px is the right approach for the logo in the navigation bar. Perhaps it's good enough temporarily, but I foresee others wanting to utilize a logo from a navigation perspective and not be capped at 32 px. I did create #issue17659 so perhaps this is sufficient for now. EDITS |
|
Hey @poirazis I know it's been a minute, but would you mind providing screenshots and/or video of a BEFORE and AFTER the code change? That way I can quickly get up to speed with the functionality, and give it a review. |
- Menus automatically close when collapsible navbar is collapsed - Menu state is persisted and restored when navbar expands - Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow - Ensures smooth UX without unnecessary scrolling in collapsible mode
a568d16 to
dd46f00
Compare
|
hey @melohagan I will redo this |
addresses #17659