Skip to content

feat: auto-close menus and adjust logo size when navbar collapses#17717

Closed
poirazis wants to merge 2 commits intoBudibase:masterfrom
poirazis:fixes/collapsible_navbar
Closed

feat: auto-close menus and adjust logo size when navbar collapses#17717
poirazis wants to merge 2 commits intoBudibase:masterfrom
poirazis:fixes/collapsible_navbar

Conversation

@poirazis
Copy link
Contributor

@poirazis poirazis commented Jan 8, 2026

  • Menus automatically close when collapsible navbar is collapsed
  • Menu state is persisted and restored when navbar expands
  • Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow
  • Ensures smooth UX without unnecessary scrolling in collapsible mode

addresses #17659

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@NDCallahan
Copy link

NDCallahan commented Jan 9, 2026

just a note from an implementer's perspective:

Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow

I don't think limiting the size to 32px is the right approach for the logo in the navigation bar. Perhaps it's good enough temporarily, but I foresee others wanting to utilize a logo from a navigation perspective and not be capped at 32 px. I did create #issue17659 so perhaps this is sufficient for now.

EDITS
I could see the logo being capped, when the navigation bar collapses, but not when collapse is enabled. To do this, why wouldn't the logo dynamically decrease in size within the parent element?

@github-actions github-actions bot added the stale label Jan 23, 2026
@melohagan
Copy link
Collaborator

Hey @poirazis

I know it's been a minute, but would you mind providing screenshots and/or video of a BEFORE and AFTER the code change?

That way I can quickly get up to speed with the functionality, and give it a review.

@github-actions github-actions bot removed the stale label Feb 3, 2026
- Menus automatically close when collapsible navbar is collapsed
- Menu state is persisted and restored when navbar expands
- Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow
- Ensures smooth UX without unnecessary scrolling in collapsible mode
@poirazis poirazis force-pushed the fixes/collapsible_navbar branch from a568d16 to dd46f00 Compare February 9, 2026 10:28
@poirazis
Copy link
Contributor Author

poirazis commented Feb 9, 2026

hey @melohagan I will redo this
I messed the branch

@poirazis poirazis closed this Feb 9, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2026
@poirazis poirazis deleted the fixes/collapsible_navbar branch February 9, 2026 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants