feat: add UserFeedback crash type and feedback submission helper#162
Merged
feat: add UserFeedback crash type and feedback submission helper#162
Conversation
Add CrashType.userFeedback, CrashTypeId.userFeedback enum value, and a new postUserFeedback() helper that constructs XML callstack from a title and submits via the existing crash post pipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
daveplunkett
reviewed
Mar 5, 2026
daveplunkett
reviewed
Mar 5, 2026
Member
daveplunkett
left a comment
daveplunkett
left a comment
There was a problem hiding this comment.
Should we consider a standard package to escape XML?
daveplunkett
approved these changes
Mar 5, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace hand-rolled XML builder and escapeXml() with JSON.stringify(), which handles all escaping natively. Addresses PR review feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Good call — switched to |
bobbyg603
pushed a commit
that referenced
this pull request
Mar 9, 2026
# [14.5.0](v14.4.0...v14.5.0) (2026-03-09) ### Features * add UserFeedback crash type and feedback submission helper ([#162](#162)) ([a50c684](a50c684))
Member
Author
|
🎉 This PR is included in version 14.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrashType.userFeedback(User.Feedback/ 36)postUserFeedback()helper that builds<feedback>XML and uploads with correct crash typeUserFeedbackOptionsinterface withtitle,description,user,email,attachments, and genericattributesfeedback.jsonbuildFeedbackJson)unit testsTest plan
npm test— all 216 specs passpostUserFeedback()sends correct crash type and attributes🤖 Generated with Claude Code