pyrenew_builder delegates validation of observational data to observation classes#698
pyrenew_builder delegates validation of observational data to observation classes#698cdc-mitzimorris merged 23 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
+ Coverage 97.43% 97.73% +0.29%
==========================================
Files 51 51
Lines 1523 1542 +19
==========================================
+ Hits 1484 1507 +23
+ Misses 39 35 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for your contribution @cdc-mitzimorris 🚀! Your github-pages is ready for download 👉 here 👈! |
dylanhmorris
left a comment
There was a problem hiding this comment.
LGTM! A few minor suggestions.
|
@dylanhmorris - fixed inconsistent/incomplete data validation - moved logic into base class. thanks for being picky. |
|
Thanks @cdc-mitzimorris! I think you can fix pre-commit issues and merge |
…new into mem_678_delegate_validation
Issue #678: Delegate observation data validation to observation processes
Changes made:
_validate_subpop_indices(), _validate_obs_times_length()
length match)
dense obs length test; made match patterns less brittle