Skip to content

Comments

Add name to RandomVariable abstract base class and all concrete implementations.#703

Merged
dylanhmorris merged 27 commits intomainfrom
mem_697_rv_names
Feb 12, 2026
Merged

Add name to RandomVariable abstract base class and all concrete implementations.#703
dylanhmorris merged 27 commits intomainfrom
mem_697_rv_names

Conversation

@cdc-mitzimorris
Copy link
Collaborator

This PR implements the plan and discussion in #697

  • all RandomVariable classes have a default name; names are consistent across related RVs, e.g., "diff" for differenced everywhere.

  • unit tests use RV name everywhere, tests of this requirement and checks that names are set correctly are consolidated into test file test/test_interface_coverage.py

  • tutorials updated as needed.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.87%. Comparing base (00352ea) to head (d6f1f4a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   97.85%   97.87%   +0.01%     
==========================================
  Files          51       51              
  Lines        1542     1555      +13     
==========================================
+ Hits         1509     1522      +13     
  Misses         33       33              
Flag Coverage Δ
unittests 97.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Thank you for your contribution @cdc-mitzimorris 🚀! Your github-pages is ready for download 👉 here 👈!
(The artifact expires on 2026-02-19T22:22:14Z. You can re-generate it by re-running the workflow here.)

@cdc-mitzimorris
Copy link
Collaborator Author

@dylanhmorris @damonbayer ready for review

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdc-mitzimorris. One test needed (or flag for me if it's there and I missed it).

@cdc-mitzimorris
Copy link
Collaborator Author

@dylanhmorris - changes made - ready for re-review

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cdc-mitzimorris!

@dylanhmorris dylanhmorris merged commit 3ba4ab0 into main Feb 12, 2026
8 checks passed
@dylanhmorris dylanhmorris deleted the mem_697_rv_names branch February 12, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants