Add name to RandomVariable abstract base class and all concrete implementations.#703
Add name to RandomVariable abstract base class and all concrete implementations.#703dylanhmorris merged 27 commits intomainfrom
name to RandomVariable abstract base class and all concrete implementations.#703Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
==========================================
+ Coverage 97.85% 97.87% +0.01%
==========================================
Files 51 51
Lines 1542 1555 +13
==========================================
+ Hits 1509 1522 +13
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
Thank you for your contribution @cdc-mitzimorris 🚀! Your github-pages is ready for download 👉 here 👈! |
|
@dylanhmorris @damonbayer ready for review |
There was a problem hiding this comment.
Thanks, @cdc-mitzimorris. One test needed (or flag for me if it's there and I missed it).
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
|
@dylanhmorris - changes made - ready for re-review |
dylanhmorris
left a comment
There was a problem hiding this comment.
LGTM, thanks @cdc-mitzimorris!
This PR implements the plan and discussion in #697
all
RandomVariableclasses have a default name; names are consistent across related RVs, e.g., "diff" for differenced everywhere.unit tests use RV name everywhere, tests of this requirement and checks that names are set correctly are consolidated into test file
test/test_interface_coverage.pytutorials updated as needed.