Skip to content

Patch Target Data Row Duplication Bug#152

Open
O957 wants to merge 2 commits intomainfrom
upx3_patch_bug_with_duplicate_rows_in_target_data
Open

Patch Target Data Row Duplication Bug#152
O957 wants to merge 2 commits intomainfrom
upx3_patch_bug_with_duplicate_rows_in_target_data

Conversation

@O957
Copy link
Collaborator

@O957 O957 commented Feb 18, 2026

This PR adds protection for situations where target data in one of the hubs is manually generated, before the scheduled run, and then the PR from the scheduled run is accidentally merged. Historically, accidentally merging the target data from the second PR duplicated the rows, which this PR prevents.

@O957 O957 self-assigned this Feb 18, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.82%. Comparing base (60bd013) to head (1fc4957).

Files with missing lines Patch % Lines
R/update_hub_target_data.R 29.16% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #152      +/-   ##
========================================
+ Coverage   9.66%   9.82%   +0.16%     
========================================
  Files         12      12              
  Lines       1180    1201      +21     
========================================
+ Hits         114     118       +4     
- Misses      1066    1083      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dylanhmorris
Copy link
Contributor

With slight revision, this PR could address #66. Can you revise so that it does?

@O957
Copy link
Collaborator Author

O957 commented Feb 18, 2026

Re: #152 (comment). Yes, sounds good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, could you just call dplyr::distinct before saving?

@O957 O957 linked an issue Feb 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle repeated target data updates with the same as-of date

4 participants

Comments