Skip to content

Conversation

@sei-vsarvepalli
Copy link
Contributor

This does not completely move to the proposed HTML format, but has the helper method added dt2df_html that we can decide to use later.

There are also other small fixes here

  1. docs/howto/supplier_tree.md runaway sting fixed
  2. src/README.cd move the ascii_tree method to helpers where it belongs instead of base.py
  3. update to both src/ssvc/decision_tables/base.py and src/ssvc/decision_tables/helpers.py (type hinting on df2dt_md also corrected)
 def dt2df_md(
-    dt: "DecisionTable",
+    dt: DecisionTable,
     longform: bool = True,
 ) -> str:

Copy link
Contributor

@ahouseholder ahouseholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We should have a separate conversation about whether we want to move some of these functions into DecisionTable class methods, or if we want to try to keep data objects separate from functions. There are good reasons for both, but we should probably pick one as an architecture choice and be consistent with it.

@ahouseholder ahouseholder merged commit 4d1249c into main Sep 16, 2025
5 checks passed
@ahouseholder ahouseholder deleted the issue_966 branch September 16, 2025 14:00
@ahouseholder ahouseholder added this to the 2025-09 milestone Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants