Enable RVE elf flag for cheriot ABIs #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Change seems fine to me. Can we add a test for it? |
Collaborator
|
Also, this is a binary compatibility break, so we'll need to notify folks to rebuild their stuff |
This must match other objects that have `EF_RISCV_RVE` set in their ELF header. CHERIoT targets use XLEN=16 (E).
Author
|
I've added a test that checks the flags for specifically the cheriot CPU and ABI |
|
I’d probably hold off merging this until after we’ve fixed #9. We need to be reporting Xcheriotv1 as an extension and putting this in the ELF as well. |
Collaborator
|
This will be subsumed by #140 |
Author
|
Perfect, thanks for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EF_RISCV_RVEflag in ELF headers must match for all objects when linking. CHERIoT targets useXLEN=1616 integer registers (E), so I think this should be set.Tested by linking to objects that did have the
RVEflag set. Before this patch the linker complained about the mismatch: